Page MenuHomePhabricator

[XRay] [compiler-rt] reformat and clarify CMakeLists.txt [NFC]
ClosedPublic

Authored by pelikan on Apr 12 2018, 6:59 AM.

Details

Summary
  • last change (+ the Apple support change) missed a lot of indentation
  • shorten architecture SOURCES definitions as most fit 1 line/arch
  • comment in English what's where, and where the different .a come from (using only the word "runtime" in the comment isn't useful, since the CMake primitive itself says "runtime" in its name)
  • skip unsupported architectures quickly, to avoid extra indentation

Event Timeline

pelikan created this revision.Apr 12 2018, 6:59 AM
Herald added subscribers: Restricted Project, delcypher, mgorny. · View Herald TranscriptApr 12 2018, 6:59 AM
kpw accepted this revision.Apr 12 2018, 1:41 PM

Thanks for the cleanup.

This revision is now accepted and ready to land.Apr 12 2018, 1:41 PM
pelikan updated this revision to Diff 142350.Apr 13 2018, 1:38 AM

sync & commit

This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.