Page MenuHomePhabricator

kpw (Keith)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 12 2017, 6:57 PM (139 w, 5 d)

Recent Activity

Aug 9 2018

kpw added a comment to D50441: [XRay] FDR Trace Dump Tool (FDR Trace Loading Refactor).

Thought that occurred to me this morning:

Aug 9 2018, 10:22 AM

Aug 8 2018

kpw added a comment to D50441: [XRay] FDR Trace Dump Tool (FDR Trace Loading Refactor).

Suggestion for splitting this up.

Aug 8 2018, 11:13 PM

Aug 6 2018

kpw accepted D50169: [XRay] Improve error reporting when loading traces.

Consider creating wrapper functions around DataExtractor's getU64, getU32, getU16, and getU8 that take a DataExtractor&, an Offset&, a descriptive twine, and return an Expected<T>. I'm trying to come up with ideas to keep all the granular checks as you desire, but pull some of the ceremonial noise out of the flow of the main logic.

Aug 6 2018, 1:20 AM

Aug 5 2018

kpw added inline comments to D50169: [XRay] Improve error reporting when loading traces.
Aug 5 2018, 2:43 PM

Aug 3 2018

kpw accepted D50129: [XRay][tools] Use Support/JSON.h in llvm-xray convert.
Aug 3 2018, 1:34 AM

Aug 2 2018

kpw added a comment to D50129: [XRay][tools] Use Support/JSON.h in llvm-xray convert.

This is way easier to read now. Did you sanity check loading a trace into chrome trace viewer that it outputs?

Aug 2 2018, 11:22 PM
kpw accepted D48370: [XRay][llvm] Load XRay Profiles.

Please consider my comments about the tests before pushing.

Aug 2 2018, 9:42 PM

Jul 31 2018

kpw added a comment to D48370: [XRay][llvm] Load XRay Profiles.

Haven't read the test yet. Logic looks sound.

Jul 31 2018, 11:19 PM

Jul 19 2018

kpw added a comment to D48370: [XRay][llvm] Load XRay Profiles.

Publishing existing comments. Haven't reviewed the whole patch.

Jul 19 2018, 5:19 PM

Jul 12 2018

kpw accepted D48956: [XRay][compiler-rt] Profiling Mode: Flush logs on exit.
Jul 12 2018, 8:54 AM

Jul 11 2018

kpw added a comment to D48956: [XRay][compiler-rt] Profiling Mode: Flush logs on exit.

Just one concern about exit handler being too aggressive if normal operation finalized and flushed.

Jul 11 2018, 4:26 PM

Jul 10 2018

kpw added a comment to D48370: [XRay][llvm] Load XRay Profiles.

Is this still a work in progress patch as noted? I'll make some time to look at this today.

Jul 10 2018, 9:53 AM

Jul 9 2018

kpw accepted D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.

Seems like half of this change is DCHECKS. Much better coverage! Was that just a result of your strategy for diagnosing what actually caused the problems and leaving those in?

Jul 9 2018, 10:15 PM

Jun 11 2018

kpw accepted D44620: [XRay][profiler] Part 4: Profiler Mode Wiring.
Jun 11 2018, 6:35 PM

Jun 8 2018

kpw added a comment to D44620: [XRay][profiler] Part 4: Profiler Mode Wiring.

I'm going to have to download the renamed files to diff locally. Is there a way to do this in Differential that I'm missing?

Jun 8 2018, 6:16 PM

Jun 6 2018

kpw accepted D46998: [XRay][compiler-rt] Remove reliance on C++ ABI features.
Jun 6 2018, 11:53 PM
kpw added inline comments to D46998: [XRay][compiler-rt] Remove reliance on C++ ABI features.
Jun 6 2018, 10:24 AM

Jun 4 2018

kpw accepted D47695: [XRay][compiler-rt] Remove reliance on C++ ABI from BufferQueue.
Jun 4 2018, 6:39 PM

May 30 2018

kpw added inline comments to D46998: [XRay][compiler-rt] Remove reliance on C++ ABI features.
May 30 2018, 10:48 PM
kpw accepted D45758: [XRay][profiler] Part 3: Profile Collector Service.

Aside from the discussion about a more invasive change to the way cooperative state transitions, this is fine. Thanks for writing the test for serialization.

May 30 2018, 7:03 PM

May 23 2018

kpw accepted D45998: [XRay][profiler] Part 5: Profiler File Writing.

LGTM, once the dependent changes get in.

May 23 2018, 6:20 PM
kpw added a comment to D44620: [XRay][profiler] Part 4: Profiler Mode Wiring.

in the chain* I meant.

May 23 2018, 6:05 PM
kpw added a comment to D44620: [XRay][profiler] Part 4: Profiler Mode Wiring.

This one is more straightforward than the previous in the change. The main ideas all fall into place nicely, but I have pointed out some details that could use some attention.

May 23 2018, 6:05 PM

May 17 2018

kpw added a comment to D45758: [XRay][profiler] Part 3: Profile Collector Service.

My overall feedback about this code is that after reading it, it probably deserves another pass over just to focus on what allocates and frees and which state transitions are responsible for closing the loops.

May 17 2018, 12:54 AM

May 14 2018

kpw accepted D45757: [XRay][profiler] Part 2: XRay Function Call Trie.
May 14 2018, 8:39 AM

May 13 2018

kpw added a comment to D45757: [XRay][profiler] Part 2: XRay Function Call Trie.

This was easier to review than I expected. I found it easier to follow than the allocator/array CL. Sorry for the long delay!

May 13 2018, 10:34 PM
kpw accepted D46574: [XRay][compiler-rt] Support in-memory processing of FDR mode logs.
May 13 2018, 1:18 PM

May 3 2018

kpw accepted D46174: [XRay][compiler-rt] Support string-based config for FDR mode.
May 3 2018, 10:40 PM
kpw accepted D46173: [XRay][compiler-rt+docs] Introduce __xray_log_init_mode(...)..

LGTM.

May 3 2018, 10:30 PM
kpw accepted D46246: [XRay][compiler-rt] Support string-based config for Basic mode..
May 3 2018, 8:28 PM
kpw added a comment to D46174: [XRay][compiler-rt] Support string-based config for FDR mode.

Can you add some Reports, which could be guarded behind sanitizer verbose, for warning messages when users do deprecated things? This looks sensible, but a bit of nagging incentives people to change.

May 3 2018, 4:34 PM
kpw added a comment to D46173: [XRay][compiler-rt+docs] Introduce __xray_log_init_mode(...)..

Everything looks good except I'd like to see us flexible for mode configuration that may contain nulls.

May 3 2018, 4:10 PM

Apr 28 2018

kpw accepted D45756: [XRay][profiler] Part 1: XRay Allocator and Array Implementations.

This looks better now, although there were a few issues that slipped through the tests and I wonder if there are others lurking.

Apr 28 2018, 8:24 PM

Apr 22 2018

kpw added a comment to D45756: [XRay][profiler] Part 1: XRay Allocator and Array Implementations.

Finally reached the end. Phew!

Apr 22 2018, 7:27 PM

Apr 19 2018

kpw added a comment to D45793: [XRay][compiler-rt] - Dedupe xray event type strings from different addresses..

Haven't made any changes yet. Thanks for the comments Dean.

Apr 19 2018, 5:32 PM
kpw added inline comments to D45756: [XRay][profiler] Part 1: XRay Allocator and Array Implementations.
Apr 19 2018, 5:26 PM

Apr 18 2018

kpw created D45793: [XRay][compiler-rt] - Dedupe xray event type strings from different addresses..
Apr 18 2018, 7:36 PM
kpw added a comment to D45756: [XRay][profiler] Part 1: XRay Allocator and Array Implementations.

Haven't looked at segmented array yet, but I had a good look at the allocator. I think I caught one serious bug, and the rest is just suggestions.

Apr 18 2018, 6:17 PM

Apr 17 2018

kpw committed rL330231: [XRay][compiler-rt] Add noop patch functions for unsupported arches..
[XRay][compiler-rt] Add noop patch functions for unsupported arches.
Apr 17 2018, 4:22 PM
kpw committed rCRT330231: [XRay][compiler-rt] Add noop patch functions for unsupported arches..
[XRay][compiler-rt] Add noop patch functions for unsupported arches.
Apr 17 2018, 4:22 PM
kpw closed D45749: [XRay][compiler-rt] Add noop patch functions for unsupported arches..
Apr 17 2018, 4:22 PM
kpw created D45749: [XRay][compiler-rt] Add noop patch functions for unsupported arches..
Apr 17 2018, 4:20 PM
kpw committed rC330220: [XRay] Add clang builtin for xray typed events..
[XRay] Add clang builtin for xray typed events.
Apr 17 2018, 2:38 PM
kpw committed rL330220: [XRay] Add clang builtin for xray typed events..
[XRay] Add clang builtin for xray typed events.
Apr 17 2018, 2:38 PM
kpw closed D45716: [XRay] Add clang builtin for xray typed events..
Apr 17 2018, 2:38 PM
kpw closed D45716: [XRay] Add clang builtin for xray typed events..
Apr 17 2018, 2:38 PM
kpw committed rL330219: [XRay] Typed event logging intrinsic.
[XRay] Typed event logging intrinsic
Apr 17 2018, 2:34 PM
kpw closed D45633: [XRay] Typed event logging intrinsic.
Apr 17 2018, 2:33 PM
kpw committed rCRT330218: Implement trampoline and handler for typed xray event tracing..
Implement trampoline and handler for typed xray event tracing.
Apr 17 2018, 2:33 PM
kpw committed rL330218: Implement trampoline and handler for typed xray event tracing..
Implement trampoline and handler for typed xray event tracing.
Apr 17 2018, 2:33 PM
kpw closed D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing..
Apr 17 2018, 2:33 PM
kpw closed D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing..
Apr 17 2018, 2:33 PM
kpw added a comment to D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing..

I'm going to land this and the llvm/clang changes and in a separate CL make some improvements as discussed offline for event type registration (handling deduping event descriptors).

Apr 17 2018, 9:58 AM
kpw updated the diff for D45716: [XRay] Add clang builtin for xray typed events..

Undoing formatting change.

Apr 17 2018, 9:55 AM

Apr 16 2018

kpw added a comment to D45716: [XRay] Add clang builtin for xray typed events..

My editor got a bit carried away with automatically clang-formatting lib/CodeGen/CodeGenFunction.cpp. I'll fix that so that I'm not messing up the revision history.

Apr 16 2018, 11:02 PM
kpw updated the diff for D45716: [XRay] Add clang builtin for xray typed events..

Added flags and bundle options.

Apr 16 2018, 10:48 PM
kpw added inline comments to D45716: [XRay] Add clang builtin for xray typed events..
Apr 16 2018, 9:49 PM
kpw updated the diff for D45716: [XRay] Add clang builtin for xray typed events..

Adding a comment to the test to encourage getting the event types from
compiler-rt

Apr 16 2018, 9:45 PM
kpw created D45716: [XRay] Add clang builtin for xray typed events..
Apr 16 2018, 9:42 PM
kpw added a child revision for D45633: [XRay] Typed event logging intrinsic: D45716: [XRay] Add clang builtin for xray typed events..
Apr 16 2018, 9:42 PM

Apr 15 2018

kpw added inline comments to D45633: [XRay] Typed event logging intrinsic.
Apr 15 2018, 1:23 PM

Apr 13 2018

kpw added a comment to D45633: [XRay] Typed event logging intrinsic.

Adding some comments for questions I had. Please chime in if you can shed light on these.

Apr 13 2018, 11:35 AM
kpw created D45633: [XRay] Typed event logging intrinsic.
Apr 13 2018, 11:29 AM

Apr 12 2018

kpw updated the diff for D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing..

[XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing.

Apr 12 2018, 6:31 PM
kpw added inline comments to D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing..
Apr 12 2018, 4:44 PM
kpw added a comment to D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing..

These comments were dangling for a while, so I'm posting an update. Currently compiling llvm with a new intrinsic to match. Fingers crossed!

Apr 12 2018, 4:29 PM
kpw updated the diff for D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing..

[XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing.

Apr 12 2018, 4:28 PM
kpw accepted D45568: [XRay] [compiler-rt] reformat and clarify CMakeLists.txt [NFC].

Thanks for the cleanup.

Apr 12 2018, 1:41 PM

Mar 6 2018

kpw accepted D43495: [XRay][compiler-rt] Add APIs for processing logs in memory.

Good point about preserving the size and structure of XRayLogImpl for ABI compatibility. Piper monorepo has lulled me into a false sense of security!

Mar 6 2018, 5:54 PM

Feb 26 2018

kpw added a comment to D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing..

Thanks for the feedback Dean.

Feb 26 2018, 5:50 PM
kpw added reviewers for D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing.: pelikan, eizan.
Feb 26 2018, 3:14 PM
kpw added a comment to D43495: [XRay][compiler-rt] Add APIs for processing logs in memory.

Mostly looks good, but I think you should consider making the buffer iterator interface part of XRayLogImpl or some other mechanism to associate it with a logging mode.

Feb 26 2018, 10:35 AM

Feb 23 2018

kpw updated the diff for D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing..
  • Jump 20
Feb 23 2018, 4:48 PM

Feb 22 2018

kpw created D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing..
Feb 22 2018, 7:09 PM

Dec 13 2017

kpw accepted D41153: [XRay][compiler-rt] Coalesce calls to mprotect to reduce patching overhead.

Thanks for pointing out the scope cleanup from MProtectHelper and making some improvements/clarifications.

Dec 13 2017, 5:48 PM
kpw added a comment to D41153: [XRay][compiler-rt] Coalesce calls to mprotect to reduce patching overhead.

Suggestion for future changes:

Dec 13 2017, 12:38 PM

Nov 6 2017

kpw committed rL317531: [XRay] Minimal tool to convert xray traces to Chrome's Trace Event Format..
[XRay] Minimal tool to convert xray traces to Chrome's Trace Event Format.
Nov 6 2017, 4:29 PM
kpw closed D39362: [XRay] Minimal tool to convert xray traces to Chrome's Trace Event Format. by committing rL317531: [XRay] Minimal tool to convert xray traces to Chrome's Trace Event Format..
Nov 6 2017, 4:29 PM

Nov 2 2017

kpw added a comment to D39362: [XRay] Minimal tool to convert xray traces to Chrome's Trace Event Format..

Here are the revisions pre-landing. I'll probably land this tomorrow and follow up with a separate review of simple lit test cases for these conversions.

Nov 2 2017, 2:41 PM
kpw updated the diff for D39362: [XRay] Minimal tool to convert xray traces to Chrome's Trace Event Format..
  • Phabricator comments.
Nov 2 2017, 2:41 PM

Nov 1 2017

kpw added inline comments to D39362: [XRay] Minimal tool to convert xray traces to Chrome's Trace Event Format..
Nov 1 2017, 8:42 PM
kpw updated the diff for D39362: [XRay] Minimal tool to convert xray traces to Chrome's Trace Event Format..

Made some changes, particularly regarding string formatting.

Nov 1 2017, 8:42 PM

Oct 29 2017

kpw added a comment to D39362: [XRay] Minimal tool to convert xray traces to Chrome's Trace Event Format..

Thanks for taking a look Dean. Here's a link to an example trace that can be loaded up at chrome://tracing. I'll respond to your other comments tomorrow.

Oct 29 2017, 4:13 PM

Oct 26 2017

kpw created D39362: [XRay] Minimal tool to convert xray traces to Chrome's Trace Event Format..
Oct 26 2017, 11:53 PM

Oct 19 2017

kpw committed rL316192: [XRay] [docs] Document how to generate flamegraphs from xray traces..
[XRay] [docs] Document how to generate flamegraphs from xray traces.
Oct 19 2017, 3:35 PM
kpw closed D39106: [XRay] [docs] Document how to generate flamegraphs from xray traces. by committing rL316192: [XRay] [docs] Document how to generate flamegraphs from xray traces..
Oct 19 2017, 3:35 PM
kpw created D39106: [XRay] [docs] Document how to generate flamegraphs from xray traces..
Oct 19 2017, 12:54 PM

Oct 12 2017

kpw committed rL315644: Removing default case statement from covered switch..
Removing default case statement from covered switch.
Oct 12 2017, 5:06 PM
kpw committed rL315635: [XRay][tools] Updated stacks tool with flamegraph output..
[XRay][tools] Updated stacks tool with flamegraph output.
Oct 12 2017, 3:47 PM
kpw closed D38650: [XRay][tools] Updated stacks tool with flamegraph output. by committing rL315635: [XRay][tools] Updated stacks tool with flamegraph output..
Oct 12 2017, 3:47 PM
kpw updated the diff for D38650: [XRay][tools] Updated stacks tool with flamegraph output..

Updating with Dean's review comments.

Oct 12 2017, 1:54 PM

Oct 6 2017

kpw created D38650: [XRay][tools] Updated stacks tool with flamegraph output..
Oct 6 2017, 3:33 PM

Sep 7 2017

kpw committed rL312739: [XRay][tools] Disable windows for tests that use an unsupported shell redirect..
[XRay][tools] Disable windows for tests that use an unsupported shell redirect.
Sep 7 2017, 12:11 PM
kpw added inline comments to D34863: [XRay][tools] Function call stack based analysis tooling for XRay traces.
Sep 7 2017, 11:45 AM
kpw committed rL312733: [XRay][tools] Function call stack based analysis tooling for XRay traces.
[XRay][tools] Function call stack based analysis tooling for XRay traces
Sep 7 2017, 11:11 AM
kpw closed D34863: [XRay][tools] Function call stack based analysis tooling for XRay traces by committing rL312733: [XRay][tools] Function call stack based analysis tooling for XRay traces.
Sep 7 2017, 11:10 AM

Sep 5 2017

kpw updated the diff for D34863: [XRay][tools] Function call stack based analysis tooling for XRay traces.

Switch from std::for_each to range based for.

Sep 5 2017, 11:26 AM
kpw abandoned D37417: Add range based wrapper around std::for_each..
Sep 5 2017, 8:43 AM
kpw added a comment to D37417: Add range based wrapper around std::for_each..

David Blakie convinced me over email that std::for_each doesn't add value over ranged based for.

Sep 5 2017, 8:43 AM

Sep 2 2017

kpw updated the diff for D34863: [XRay][tools] Function call stack based analysis tooling for XRay traces.

Update the way an iterator type is referenced to not make assumptions about references.

Sep 2 2017, 6:13 PM