Page MenuHomePhabricator

pelikan (Martin Pelikán)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2016, 5:02 AM (168 w, 1 h)

Recent Activity

Apr 13 2018

pelikan updated the diff for D38993: [XRay] [compiler-rt] [DSO] start deciding which symbols to hide/export.

more tidbits and context

Apr 13 2018, 2:01 AM
pelikan updated the diff for D38993: [XRay] [compiler-rt] [DSO] start deciding which symbols to hide/export.

sync & add a failing test

Apr 13 2018, 1:56 AM
pelikan committed rCRT329998: [XRay] [compiler-rt] reformat and clarify CMakeLists.txt [NFC].
[XRay] [compiler-rt] reformat and clarify CMakeLists.txt [NFC]
Apr 13 2018, 1:38 AM
pelikan committed rL329998: [XRay] [compiler-rt] reformat and clarify CMakeLists.txt [NFC].
[XRay] [compiler-rt] reformat and clarify CMakeLists.txt [NFC]
Apr 13 2018, 1:38 AM
pelikan closed D45568: [XRay] [compiler-rt] reformat and clarify CMakeLists.txt [NFC].
Apr 13 2018, 1:38 AM
pelikan closed D45568: [XRay] [compiler-rt] reformat and clarify CMakeLists.txt [NFC].
Apr 13 2018, 1:38 AM
pelikan updated the diff for D45568: [XRay] [compiler-rt] reformat and clarify CMakeLists.txt [NFC].

sync & commit

Apr 13 2018, 1:38 AM

Apr 12 2018

pelikan updated the diff for D45570: [XRay] [clang] use compiler-rt's symbol visibility rules.

while there, clang-format the code I touched

Apr 12 2018, 7:27 AM
pelikan created D45570: [XRay] [clang] use compiler-rt's symbol visibility rules.
Apr 12 2018, 7:25 AM
pelikan added a child revision for D38993: [XRay] [compiler-rt] [DSO] start deciding which symbols to hide/export: D45570: [XRay] [clang] use compiler-rt's symbol visibility rules.
Apr 12 2018, 7:25 AM
pelikan created D45568: [XRay] [compiler-rt] reformat and clarify CMakeLists.txt [NFC].
Apr 12 2018, 6:59 AM
pelikan updated the summary of D38993: [XRay] [compiler-rt] [DSO] start deciding which symbols to hide/export.
Apr 12 2018, 6:31 AM
pelikan updated the diff for D38993: [XRay] [compiler-rt] [DSO] start deciding which symbols to hide/export.

rebase + try to use this diff from a different machine

Apr 12 2018, 6:19 AM
pelikan abandoned D39158: [XRay] remove an unused header outside the include directory.

I can't see the file anywhere, so someone must have deleted it.

Apr 12 2018, 5:55 AM
pelikan accepted D44970: [XRay][clang] Add flag to choose instrumentation bundles.

Most of my comments are minor enough I'd be OK if this went in. But please consider them before committing.

Apr 12 2018, 5:31 AM

Apr 11 2018

pelikan added a comment to D44620: [XRay][profiler] Part 4: Profiler Mode Wiring.

Sorry for the late review, and for destroying your diff.

Apr 11 2018, 12:34 PM

Mar 29 2018

pelikan added a comment to D44970: [XRay][clang] Add flag to choose instrumentation bundles.

I would probably add more tests for the different configurations, but I suspect more diffs are coming after this.

Mar 29 2018, 3:25 AM

Mar 15 2018

pelikan committed rCRT327621: [TSan] fix Go runtime test on amd64 with PIE.
[TSan] fix Go runtime test on amd64 with PIE
Mar 15 2018, 5:13 AM
pelikan committed rL327621: [TSan] fix Go runtime test on amd64 with PIE.
[TSan] fix Go runtime test on amd64 with PIE
Mar 15 2018, 5:13 AM
pelikan closed D44071: [TSan] fix Go runtime test on amd64 with PIE.
Mar 15 2018, 5:13 AM
pelikan updated the diff for D44071: [TSan] fix Go runtime test on amd64 with PIE.

sync again?

Mar 15 2018, 4:51 AM
pelikan updated the diff for D44071: [TSan] fix Go runtime test on amd64 with PIE.

sync again - something's wrong with Git

Mar 15 2018, 3:51 AM
pelikan updated the diff for D44071: [TSan] fix Go runtime test on amd64 with PIE.

sync to HEAD

Mar 15 2018, 3:51 AM

Mar 3 2018

pelikan updated the diff for D44071: [TSan] fix Go runtime test on amd64 with PIE.

add errno printout, in case something goes wrong on the buildbots

Mar 3 2018, 11:19 AM
pelikan created D44071: [TSan] fix Go runtime test on amd64 with PIE.
Mar 3 2018, 11:01 AM

Feb 28 2018

pelikan added inline comments to D43892: [YAML] speed up isNumber by doing regex matching less often.
Feb 28 2018, 6:09 PM
pelikan updated the diff for D43892: [YAML] speed up isNumber by doing regex matching less often.

sync

Feb 28 2018, 6:09 PM
pelikan committed rL326407: [XRay] cache symbolized function names for a repeatedly queried function ID.
[XRay] cache symbolized function names for a repeatedly queried function ID
Feb 28 2018, 6:03 PM
pelikan closed D43896: [XRay] cache symbolized function names for a repeatedly queried function ID.
Feb 28 2018, 6:03 PM
pelikan added inline comments to D43896: [XRay] cache symbolized function names for a repeatedly queried function ID.
Feb 28 2018, 6:00 PM
pelikan updated the diff for D43896: [XRay] cache symbolized function names for a repeatedly queried function ID.

std::unordered_map -> llvm::DenseMap (as requested)

Feb 28 2018, 6:00 PM
pelikan updated the summary of D43896: [XRay] cache symbolized function names for a repeatedly queried function ID.
Feb 28 2018, 1:03 PM
pelikan updated the summary of D43896: [XRay] cache symbolized function names for a repeatedly queried function ID.
Feb 28 2018, 1:02 PM
pelikan created D43896: [XRay] cache symbolized function names for a repeatedly queried function ID.
Feb 28 2018, 1:01 PM
pelikan created D43892: [YAML] speed up isNumber by doing regex matching less often.
Feb 28 2018, 12:41 PM

Jan 30 2018

pelikan committed rL323800: [XRay] fix 99th percentile lookups by sorting the array correctly.
[XRay] fix 99th percentile lookups by sorting the array correctly
Jan 30 2018, 10:20 AM
pelikan closed D42690: [XRay] fix 99th percentile lookups by sorting the array correctly.
Jan 30 2018, 10:20 AM
pelikan updated the diff for D42690: [XRay] fix 99th percentile lookups by sorting the array correctly.

sync

Jan 30 2018, 10:19 AM
pelikan added inline comments to D42690: [XRay] fix 99th percentile lookups by sorting the array correctly.
Jan 30 2018, 9:30 AM
pelikan updated the diff for D42690: [XRay] fix 99th percentile lookups by sorting the array correctly.

reorder like it used to be

Jan 30 2018, 9:30 AM
pelikan added inline comments to D42690: [XRay] fix 99th percentile lookups by sorting the array correctly.
Jan 30 2018, 9:16 AM
pelikan updated the summary of D42690: [XRay] fix 99th percentile lookups by sorting the array correctly.
Jan 30 2018, 9:16 AM
pelikan updated the diff for D42690: [XRay] fix 99th percentile lookups by sorting the array correctly.

nth_element doesn't actually order things on either side; put them back

Jan 30 2018, 9:16 AM
pelikan created D42690: [XRay] fix 99th percentile lookups by sorting the array correctly.
Jan 30 2018, 6:59 AM
pelikan committed rL323758: [XRay] clarify error messages when parsing broken traces.
[XRay] clarify error messages when parsing broken traces
Jan 30 2018, 5:43 AM
pelikan closed D42492: [XRay] clarify error messages when parsing broken traces.
Jan 30 2018, 5:43 AM
pelikan committed rCRT323755: [XRay] [compiler-rt] stop writing garbage in naive log records.
[XRay] [compiler-rt] stop writing garbage in naive log records
Jan 30 2018, 5:29 AM
pelikan committed rL323755: [XRay] [compiler-rt] stop writing garbage in naive log records.
[XRay] [compiler-rt] stop writing garbage in naive log records
Jan 30 2018, 5:27 AM
pelikan closed D42494: [XRay] [compiler-rt] stop writing garbage in naive log records.
Jan 30 2018, 5:27 AM
pelikan updated the diff for D42492: [XRay] clarify error messages when parsing broken traces.

sync

Jan 30 2018, 5:19 AM
pelikan updated the diff for D42494: [XRay] [compiler-rt] stop writing garbage in naive log records.

sync

Jan 30 2018, 5:19 AM

Jan 24 2018

pelikan added a comment to D42492: [XRay] clarify error messages when parsing broken traces.

FWIW, I've been seeing signal handler traces written between ENTER_ARG and ARG_PAYLOAD.

Jan 24 2018, 9:51 AM
pelikan created D42494: [XRay] [compiler-rt] stop writing garbage in naive log records.
Jan 24 2018, 9:46 AM
pelikan created D42492: [XRay] clarify error messages when parsing broken traces.
Jan 24 2018, 9:13 AM

Jan 19 2018

pelikan committed rCRT322941: [XRay] [compiler-rt] fix heap overflow by computing record pointers correctly.
[XRay] [compiler-rt] fix heap overflow by computing record pointers correctly
Jan 19 2018, 5:20 AM
pelikan committed rL322941: [XRay] [compiler-rt] fix heap overflow by computing record pointers correctly.
[XRay] [compiler-rt] fix heap overflow by computing record pointers correctly
Jan 19 2018, 5:20 AM
pelikan closed D42289: [XRay] [compiler-rt] fix heap overflow by computing record pointers correctly.
Jan 19 2018, 5:20 AM
pelikan created D42289: [XRay] [compiler-rt] fix heap overflow by computing record pointers correctly.
Jan 19 2018, 3:21 AM

Nov 20 2017

pelikan accepted D40164: [XRay][compiler-rt] Migrate basic mode logging to the XRay framework.

Although it looks better than the original, there's a lot going on and I can't guarantee I haven't missed some stupid typo. Basically, LGTM.

Nov 20 2017, 11:25 PM
pelikan accepted D39526: [XRay] Use optimistic logging model for FDR mode.
Nov 20 2017, 9:58 PM

Nov 15 2017

pelikan added a comment to D39526: [XRay] Use optimistic logging model for FDR mode.

still not 100% finished - I'll get to it tomorrow. I am convinced the overall concept will work though.

Nov 15 2017, 8:31 PM
pelikan added a comment to D39526: [XRay] Use optimistic logging model for FDR mode.

partial review only

Nov 15 2017, 8:08 PM

Oct 27 2017

pelikan committed rL316821: [XRay] [compiler-rt] fix build by including errno.h into FDR mode.
[XRay] [compiler-rt] fix build by including errno.h into FDR mode
Oct 27 2017, 6:35 PM

Oct 22 2017

pelikan accepted D39175: [XRay][compiler-rt] Remove C++ STL from the buffer queue implementation.
Oct 22 2017, 11:17 PM

Oct 21 2017

pelikan created D39158: [XRay] remove an unused header outside the include directory.
Oct 21 2017, 2:18 AM
pelikan created D39157: fix typo in a CMake SANITIZER_CAN_USE_CXXABI variable initial definition.
Oct 21 2017, 2:07 AM

Oct 17 2017

pelikan accepted D38995: [XRay][compiler-rt] Always place the CPU record first for every buffer.
Oct 17 2017, 3:32 AM
pelikan created D38993: [XRay] [compiler-rt] [DSO] start deciding which symbols to hide/export.
Oct 17 2017, 1:56 AM
pelikan created D38990: [XRay] [compiler-rt] [DSO] introduce a context for patching/unpatching.
Oct 17 2017, 1:08 AM

Oct 4 2017

pelikan accepted D38550: [XRay][tools] Support arg1 logging entries in the basic logging mode.

LGTM now. Let's see what breaks :-)

Oct 4 2017, 10:01 PM
pelikan accepted D38551: [XRay][compiler-rt] Write out arg1 payload in naive mode logging.

I still don't like how we handle TSC vs. emulation here, but that's not the point of this diff.

Oct 4 2017, 9:57 PM
pelikan added inline comments to D38550: [XRay][tools] Support arg1 logging entries in the basic logging mode.
Oct 4 2017, 9:47 PM

Oct 3 2017

pelikan committed rL314875: [XRay] [compiler-rt] make sure single threaded programs get traced too.
[XRay] [compiler-rt] make sure single threaded programs get traced too
Oct 3 2017, 10:13 PM
pelikan closed D38493: [XRay] [compiler-rt] make sure single threaded programs get traced too by committing rL314875: [XRay] [compiler-rt] make sure single threaded programs get traced too.
Oct 3 2017, 10:13 PM
pelikan added inline comments to D38493: [XRay] [compiler-rt] make sure single threaded programs get traced too.
Oct 3 2017, 5:28 PM
pelikan updated the diff for D38493: [XRay] [compiler-rt] make sure single threaded programs get traced too.

break up RUN: lines in the test

Oct 3 2017, 5:28 PM
pelikan created D38493: [XRay] [compiler-rt] make sure single threaded programs get traced too.
Oct 3 2017, 12:02 AM

Oct 2 2017

pelikan added a comment to D38073: [XRay][compiler-rt] Use pthread for initializing thread-local data.

Technically, the pthread functions can return EAGAIN or ENOMEM but it (ehm) "should not happen in this case". Really. I mean, come on!

Oct 2 2017, 10:22 PM
pelikan accepted D38073: [XRay][compiler-rt] Use pthread for initializing thread-local data.
Oct 2 2017, 10:11 PM
pelikan accepted D38119: [XRay][compiler-rt] Use a hand-written circular buffer in BufferQueue.

I'm wondering how much will all the malloc(3) calls in one thread impact the thread locality work done in tcmalloc. Better ask a tcmalloc expert though, I've lost track of what's going on.

Oct 2 2017, 7:32 PM

Sep 27 2017

pelikan committed rL314378: [XRay] [compiler-rt] FDR logging arg1 handler.
[XRay] [compiler-rt] FDR logging arg1 handler
Sep 27 2017, 10:31 PM
pelikan closed D32844: [XRay] [compiler-rt] FDR logging arg1 handler by committing rL314378: [XRay] [compiler-rt] FDR logging arg1 handler.
Sep 27 2017, 10:31 PM
pelikan updated the diff for D32844: [XRay] [compiler-rt] FDR logging arg1 handler.

latest update before commit

Sep 27 2017, 10:30 PM
pelikan added inline comments to D32844: [XRay] [compiler-rt] FDR logging arg1 handler.
Sep 27 2017, 10:30 PM
pelikan updated the diff for D32844: [XRay] [compiler-rt] FDR logging arg1 handler.

address comment

Sep 27 2017, 8:32 PM
pelikan updated the diff for D32844: [XRay] [compiler-rt] FDR logging arg1 handler.

address yesterday's discussion

Sep 27 2017, 5:46 PM
pelikan committed rL314278: [XRay] initialize all members of YAMLXRayRecord for -Wmissing-field-initializers.
[XRay] initialize all members of YAMLXRayRecord for -Wmissing-field-initializers
Sep 27 2017, 12:32 AM

Sep 26 2017

pelikan added inline comments to D32844: [XRay] [compiler-rt] FDR logging arg1 handler.
Sep 26 2017, 10:55 PM
pelikan updated the diff for D32844: [XRay] [compiler-rt] FDR logging arg1 handler.

rebase to HEAD

Sep 26 2017, 10:54 PM
pelikan committed rL314270: [XRay] fix the -Werror build by handling all enum cases in switches.
[XRay] fix the -Werror build by handling all enum cases in switches
Sep 26 2017, 10:12 PM
pelikan committed rL314269: [XRay] convert FDR arg1 log entries.
[XRay] convert FDR arg1 log entries
Sep 26 2017, 9:49 PM
pelikan closed D32840: [XRay] convert FDR arg1 log entries by committing rL314269: [XRay] convert FDR arg1 log entries.
Sep 26 2017, 9:49 PM
pelikan updated the diff for D32840: [XRay] convert FDR arg1 log entries.

rebase again; tests now pass

Sep 26 2017, 9:44 PM

Sep 20 2017

pelikan accepted D38121: [XRay][compiler-rt] Remove non-trivial globals from xray_log_interface.cc.

I like how we're moving forward to C. LGTM.

Sep 20 2017, 11:50 PM

Sep 19 2017

pelikan updated the diff for D32840: [XRay] convert FDR arg1 log entries.

rebase to HEAD

Sep 19 2017, 11:14 PM
pelikan added inline comments to D32840: [XRay] convert FDR arg1 log entries.
Sep 19 2017, 11:14 PM

Sep 17 2017

pelikan added a comment to D32840: [XRay] convert FDR arg1 log entries.

I will wait for the other diff to go in then. In the meantime I can sort out my new system's toolchain issues.

Sep 17 2017, 10:26 PM
pelikan added a comment to D37964: [XRay][tools] Support tail-call exits before we write them in the runtime.

Nitpick: maybe update docs/XRayFDRFormat.rst in the same diff.

Sep 17 2017, 9:58 PM
pelikan added a child revision for D32840: [XRay] convert FDR arg1 log entries: D32844: [XRay] [compiler-rt] FDR logging arg1 handler.
Sep 17 2017, 9:54 PM
pelikan updated the summary of D32844: [XRay] [compiler-rt] FDR logging arg1 handler.
Sep 17 2017, 9:54 PM