- User Since
- Jun 29 2016, 5:02 AM (238 w, 14 h)
Apr 13 2018
more tidbits and context
sync & add a failing test
sync & commit
Apr 12 2018
while there, clang-format the code I touched
rebase + try to use this diff from a different machine
I can't see the file anywhere, so someone must have deleted it.
Most of my comments are minor enough I'd be OK if this went in. But please consider them before committing.
Apr 11 2018
Sorry for the late review, and for destroying your diff.
Mar 29 2018
I would probably add more tests for the different configurations, but I suspect more diffs are coming after this.
Mar 15 2018
sync again - something's wrong with Git
sync to HEAD
Mar 3 2018
add errno printout, in case something goes wrong on the buildbots
Feb 28 2018
std::unordered_map -> llvm::DenseMap (as requested)
Jan 30 2018
reorder like it used to be
nth_element doesn't actually order things on either side; put them back
Jan 24 2018
FWIW, I've been seeing signal handler traces written between ENTER_ARG and ARG_PAYLOAD.
Jan 19 2018
Nov 20 2017
Although it looks better than the original, there's a lot going on and I can't guarantee I haven't missed some stupid typo. Basically, LGTM.
Nov 15 2017
still not 100% finished - I'll get to it tomorrow. I am convinced the overall concept will work though.
partial review only
Oct 27 2017
Oct 22 2017
Oct 21 2017
Oct 17 2017
Oct 4 2017
LGTM now. Let's see what breaks :-)
I still don't like how we handle TSC vs. emulation here, but that's not the point of this diff.
Oct 3 2017
break up RUN: lines in the test
Oct 2 2017
Technically, the pthread functions can return EAGAIN or ENOMEM but it (ehm) "should not happen in this case". Really. I mean, come on!
I'm wondering how much will all the malloc(3) calls in one thread impact the thread locality work done in tcmalloc. Better ask a tcmalloc expert though, I've lost track of what's going on.
Sep 27 2017
latest update before commit
address yesterday's discussion
Sep 26 2017
rebase to HEAD
rebase again; tests now pass
Sep 20 2017
I like how we're moving forward to C. LGTM.
Sep 19 2017
rebase to HEAD
Sep 17 2017
I will wait for the other diff to go in then. In the meantime I can sort out my new system's toolchain issues.
Nitpick: maybe update docs/XRayFDRFormat.rst in the same diff.
I don't understand why do we need the version number bumped but I'm guessing you'll show me a counter-example in response to this comment.