Page MenuHomePhabricator

[CMake] Unbreak BUILD_SHARED_LIBS workflow
AbandonedPublic

Authored by davezarzycki on Apr 10 2018, 5:54 AM.

Details

Summary

Due to recent timer changes, we need to add LLVM's Core library to avoid undefined symbol errors at link time (llvm::TimePassesIsEnabled) when using LLVM's BUILD_SHARED_LIBS workflow.

Diff Detail

Repository
rC Clang

Event Timeline

davezarzycki created this revision.Apr 10 2018, 5:54 AM

Can you link to the recent timer changes?

I haven't proven that r329684 is the source of the regression, but it is the only timer related change in the last 24 hours as far as I can tell.

Thanks for the pointer! I commented on https://reviews.llvm.org/D43578; I'm hoping there's a fix that doesn't require making so many libs depend on clang's IR library.

Great! I'll revisit this patch in a week and see if it is still needed. Hopefully the author of D43578 will make this patch unnecessary by then.

davezarzycki abandoned this revision.Apr 12 2018, 11:56 AM