This is an archive of the discontinued LLVM Phabricator instance.

Differential D45424

[sanitizer] Enable threads for libc++ build used by the symbolizer
ClosedPublic

Authored by phosek on Apr 9 2018, 12:42 AM.

Details

Reviewers
vitalybuka
morehouse
EricWF
Commits
rG00b9248cb3f6: [sanitizer] Enable threads for libc++ build used by the symbolizer
rCRT329672: [sanitizer] Enable threads for libc++ build used by the symbolizer
rL329672: [sanitizer] Enable threads for libc++ build used by the symbolizer
Summary

Disabling threads makes <atomic> unusable, but this is needed by LLVM
libraries that are dependencies of the symbolizer.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Apr 9 2018, 12:42 AM
Herald added a reviewer: EricWF. · View Herald TranscriptApr 9 2018, 12:42 AM
Herald added subscribers: Restricted Project, llvm-commits, kubamracek. · View Herald Transcript
phosek added a comment.Apr 9 2018, 12:43 AM

This was discovered after landing D44773 when the builder starting failing on this line: https://reviews.llvm.org/source/libcxx/browse/libcxx/trunk/include/atomic;329545$553

vitalybuka accepted this revision.Apr 9 2018, 1:05 PM
This revision is now accepted and ready to land.Apr 9 2018, 1:05 PM
vitalybuka added inline comments.Apr 9 2018, 1:09 PM
compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
106 ↗(On Diff #141590)

We need to watch for http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux
Maybe we needs to update global_symbols.txt

phosek updated this revision to Diff 141791.Apr 9 2018, 10:53 PM
phosek added inline comments.Apr 9 2018, 10:56 PM
compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
106 ↗(On Diff #141590)

You were right, I ran everything end-to-end and global_symbols.txt indeed needed updating.

Closed by commit rL329672: [sanitizer] Enable threads for libc++ build used by the symbolizer (authored by phosek). · Explain WhyApr 9 2018, 10:57 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: delcypher. · View Herald TranscriptApr 9 2018, 10:57 PM

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
sanitizer_common/
symbolizer/
scripts/
2 lines
4 lines

Diff 141792

compiler-rt/trunk/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh

Show First 20 Lines • Show All 92 Lines • ▼ Show 20 Lines cmake -GNinja \
-DCMAKE_BUILD_TYPE=Release \ -DCMAKE_BUILD_TYPE=Release \
-DCMAKE_C_COMPILER=$CC \ -DCMAKE_C_COMPILER=$CC \
-DCMAKE_CXX_COMPILER=$CXX \ -DCMAKE_CXX_COMPILER=$CXX \
-DCMAKE_C_FLAGS_RELEASE="${LIBCXX_FLAGS}" \ -DCMAKE_C_FLAGS_RELEASE="${LIBCXX_FLAGS}" \
-DCMAKE_CXX_FLAGS_RELEASE="${LIBCXX_FLAGS}" \ -DCMAKE_CXX_FLAGS_RELEASE="${LIBCXX_FLAGS}" \
-DLIBCXXABI_ENABLE_ASSERTIONS=OFF \ -DLIBCXXABI_ENABLE_ASSERTIONS=OFF \
-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF \ -DLIBCXXABI_ENABLE_EXCEPTIONS=OFF \
-DLIBCXXABI_ENABLE_SHARED=OFF \ -DLIBCXXABI_ENABLE_SHARED=OFF \
-DLIBCXXABI_ENABLE_THREADS=OFF \
-DLIBCXX_ENABLE_ASSERTIONS=OFF \ -DLIBCXX_ENABLE_ASSERTIONS=OFF \
-DLIBCXX_ENABLE_EXCEPTIONS=OFF \ -DLIBCXX_ENABLE_EXCEPTIONS=OFF \
-DLIBCXX_ENABLE_RTTI=OFF \ -DLIBCXX_ENABLE_RTTI=OFF \
-DLIBCXX_ENABLE_SHARED=OFF \ -DLIBCXX_ENABLE_SHARED=OFF \
-DLIBCXX_ENABLE_THREADS=OFF \
$LLVM_SRC $LLVM_SRC
fi fi
cd ${LIBCXX_BUILD} cd ${LIBCXX_BUILD}
ninja cxx cxxabi ninja cxx cxxabi
FLAGS="${FLAGS} -fno-rtti -fno-exceptions" FLAGS="${FLAGS} -fno-rtti -fno-exceptions"
LLVM_FLAGS="${FLAGS} -nostdinc++ -I${ZLIB_BUILD} -I${LIBCXX_BUILD}/include/c++/v1" LLVM_FLAGS="${FLAGS} -nostdinc++ -I${ZLIB_BUILD} -I${LIBCXX_BUILD}/include/c++/v1"
▲ Show 20 Lines • Show All 72 Lines • Show Last 20 Lines

compiler-rt/trunk/lib/sanitizer_common/symbolizer/scripts/global_symbols.txt

Show All 9 Lines
_ZN11__sanitizer17internal_snprintfEPcmPKcz U _ZN11__sanitizer17internal_snprintfEPcmPKcz U
__ctype_b_loc U __ctype_b_loc U
__ctype_get_mb_cur_max U __ctype_get_mb_cur_max U
__cxa_atexit U __cxa_atexit U
__divdi3 U __divdi3 U
__dso_handle U __dso_handle U
__errno_location U __errno_location U
__interceptor_pread w __interceptor_pread w
__interceptor_pthread_cond_broadcast w
__interceptor_pthread_cond_wait w
__interceptor_pthread_mutex_lock w
__interceptor_pthread_mutex_unlock w
__interceptor_read w __interceptor_read w
__interceptor_realpath w __interceptor_realpath w
__moddi3 U __moddi3 U
__sanitizer_symbolize_code T __sanitizer_symbolize_code T
__sanitizer_symbolize_data T __sanitizer_symbolize_data T
__sanitizer_symbolize_demangle T __sanitizer_symbolize_demangle T
__sanitizer_symbolize_flush T __sanitizer_symbolize_flush T
__strdup U __strdup U
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines