This is an archive of the discontinued LLVM Phabricator instance.

llvm-exegesis: Fix unittests include dirs when llvm is a part of another project
ClosedPublic

Authored by kzhuravl on Apr 5 2018, 10:20 AM.

Download Raw Diff

Details

Reviewers

Commits

rG8e86fc4049b8: llvm-exegesis: Fix unittests include dirs when llvm is a part of another project
rL329325: llvm-exegesis: Fix unittests include dirs when llvm is a part of another project

Summary

When llvm is a part of another project (opencl in my case), CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR are pointing to the parent project, which lead to build failures.

Diff Detail

Event Timeline

kzhuravl created this revision.Apr 5 2018, 10:20 AM

Herald added subscribers: tschuett, Anastasia, mgorny, wdng. · View Herald TranscriptApr 5 2018, 10:20 AM

kzhuravl mentioned this in D44519: Add llvm-exegesis tool..Apr 5 2018, 10:21 AM

Thanks !

This revision is now accepted and ready to land.Apr 5 2018, 10:56 AM

Closed by commit rL329325: llvm-exegesis: Fix unittests include dirs when llvm is a part of another project (authored by kzhuravl). · Explain WhyApr 5 2018, 11:19 AM

This revision was automatically updated to reflect the committed changes.

msearles added a subscriber: msearles.Apr 6 2018, 6:47 AM

Revision Contents

Path

Size

unittests/

tools/

llvm-exegesis/

CMakeLists.txt

6 lines

Diff 141178

unittests/tools/llvm-exegesis/CMakeLists.txt

	include_directories(			include_directories(
	${CMAKE_SOURCE_DIR}/lib/Target/X86			${LLVM_MAIN_SRC_DIR}/lib/Target/X86
	${CMAKE_BINARY_DIR}/lib/Target/X86			${LLVM_BINARY_DIR}/lib/Target/X86
	${CMAKE_SOURCE_DIR}/tools/llvm-exegesis/lib			${LLVM_MAIN_SRC_DIR}/tools/llvm-exegesis/lib
	)			)

	set(LLVM_LINK_COMPONENTS			set(LLVM_LINK_COMPONENTS
	MC			MC
	MCParser			MCParser
	Object			Object
	Support			Support
	Symbolize			Symbolize
	Show All 16 Lines