This is an archive of the discontinued LLVM Phabricator instance.

[clangd-vscode] Update VScode dependencies
ClosedPublic

Authored by malaperle on Apr 4 2018, 1:31 PM.

Download Raw Diff

Details

Reviewers

Commits

rGc1d6b5e458ed: [clangd-vscode] Update VScode dependencies
rL329574: [clangd-vscode] Update VScode dependencies
rCTE329574: [clangd-vscode] Update VScode dependencies

Summary

This allows the extension to work with LSP 3.0 and is useful for testing.

Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Diff Detail

Repository: rCTE Clang Tools Extra

Event Timeline

malaperle created this revision.Apr 4 2018, 1:31 PM

Herald added subscribers: cfe-commits, MaskRay, ioeric and 3 others. · View Herald TranscriptApr 4 2018, 1:31 PM

malaperle retitled this revision from [clangd-vscode] Vscode dependencies to [clangd-vscode] Update VScode dependencies.Apr 4 2018, 1:31 PM

Harbormaster completed remote builds in B16731: Diff 141036.Apr 4 2018, 1:34 PM

LGTM

Do we need to bump the version of the extension and do a new release or anything like that? Or leave this for later?

Do we really want to keep editor plugins in the repository?

In D45285#1058567, @malaperle wrote:

Do we need to bump the version of the extension and do a new release or anything like that? Or leave this for later?

We should bump the version and republish the extension into VSCode marketplace.
@hokein has more context on how to properly do that.

In D45285#1058578, @MaskRay wrote:

Do we really want to keep editor plugins in the repository?

As long as we are the ones who own it, probably yes. Any downsides to keeping it here?

In D45285#1061243, @ilya-biryukov wrote:

In D45285#1058567, @malaperle wrote:

Do we need to bump the version of the extension and do a new release or anything like that? Or leave this for later?

We should bump the version and republish the extension into VSCode marketplace.
@hokein has more context on how to properly do that.

Once you commit this patch, I'm happy to make a new release.

In D45285#1058578, @MaskRay wrote:

Do we really want to keep editor plugins in the repository?

As long as we are the ones who own it, probably yes. Any downsides to keeping it here?

We used to have a separate GitHub repository for the extension, but it increased the maintaining burden (we need to syn whenever a new change is made in this repository).
Having the vscode extension in the clangd repository is the sensible way IMO.

In D45285#1061374, @hokein wrote:

In D45285#1061243, @ilya-biryukov wrote:

In D45285#1058567, @malaperle wrote:

Do we need to bump the version of the extension and do a new release or anything like that? Or leave this for later?

We should bump the version and republish the extension into VSCode marketplace.
@hokein has more context on how to properly do that.

Once you commit this patch, I'm happy to make a new release.

OK, I'll commit as-is then. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2018, 7:35 AM

Closed by commit rCTE329574: [clangd-vscode] Update VScode dependencies (authored by malaperle). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

clangd/

clients/

clangd-vscode/

package.json

8 lines

Diff 141645

clangd/clients/clangd-vscode/package.json

	{			{
	"name": "vscode-clangd",			"name": "vscode-clangd",
	"displayName": "vscode-clangd",			"displayName": "vscode-clangd",
	"description": "Clang Language Server",			"description": "Clang Language Server",
	"version": "0.0.5",			"version": "0.0.5",
	"publisher": "llvm-vs-code-extensions",			"publisher": "llvm-vs-code-extensions",
	"homepage": "https://clang.llvm.org/extra/clangd.html",			"homepage": "https://clang.llvm.org/extra/clangd.html",
	"engines": {			"engines": {
	"vscode": "^1.15.0"			"vscode": "^1.18.0"
	},			},
	"categories": [			"categories": [
	"Languages",			"Languages",
	"Linters",			"Linters",
	"Snippets"			"Snippets"
	],			],
	"keywords": [			"keywords": [
	"C",			"C",
	Show All 9 Lines
	"main": "./out/src/extension",			"main": "./out/src/extension",
	"scripts": {			"scripts": {
	"vscode:prepublish": "tsc -p ./",			"vscode:prepublish": "tsc -p ./",
	"compile": "tsc -watch -p ./",			"compile": "tsc -watch -p ./",
	"postinstall": "node ./node_modules/vscode/bin/install",			"postinstall": "node ./node_modules/vscode/bin/install",
	"test": "node ./node_modules/vscode/bin/test"			"test": "node ./node_modules/vscode/bin/test"
	},			},
	"dependencies": {			"dependencies": {
	"vscode-languageclient": "^3.3.0",			"vscode-languageclient": "^4.0.0",
	"vscode-languageserver": "^3.3.0"			"vscode-languageserver": "^4.0.0"
	},			},
	"devDependencies": {			"devDependencies": {
	"typescript": "^2.0.3",			"typescript": "^2.0.3",
	"vscode": "^1.0.3",			"vscode": "^1.1.0",
	"mocha": "^2.3.3",			"mocha": "^2.3.3",
	"@types/node": "^6.0.40",			"@types/node": "^6.0.40",
	"@types/mocha": "^2.2.32"			"@types/mocha": "^2.2.32"
	},			},
	"repository": {			"repository": {
	"type": "svn",			"type": "svn",
	"url": "http://llvm.org/svn/llvm-project/clang-tools-extra/trunk/clangd/clients/clangd-vscode/"			"url": "http://llvm.org/svn/llvm-project/clang-tools-extra/trunk/clangd/clients/clangd-vscode/"
	},			},
	Show All 31 Lines