This is an archive of the discontinued LLVM Phabricator instance.

[XRay][clang] Consolidate runtime and link-time flag processing (NFC)
ClosedPublic

Authored by dberris on Apr 3 2018, 11:52 PM.

Details

Summary

This change fixes http://llvm.org/PR36985 to define a single place in
CommonArgs.{h,cpp} where XRay runtime flags and link-time dependencies
are processed for all toolchains that support XRay instrumentation. This
is a refactoring of the same functionality spread across multiple
toolchain definitions.

Event Timeline

dberris created this revision.Apr 3 2018, 11:52 PM

Do the unit tests have same outcome with these changes ? Otherwise, appreciate the simplification.

Do the unit tests have same outcome with these changes ? Otherwise, appreciate the simplification.

Yes, locally, ninja check-all on Linux works just fine for me. No idea whether this will be the case for the buildbots, but that's easy enough to address when I get LGTM for the patch (and it lands, preferably daytime in Sydney).

That's good enough for me the changes look neat. We ll see what others think.

dberris updated this revision to Diff 141265.Apr 5 2018, 8:00 PM
  • fixup: Rebase, and re-do OpenBSD specific changes
eizan accepted this revision.Apr 5 2018, 8:49 PM
This revision is now accepted and ready to land.Apr 5 2018, 8:49 PM
This revision was automatically updated to reflect the committed changes.