Page MenuHomePhabricator

[clang-format/ObjC] Do not insert space after opening brace of ObjC dict literal
ClosedPublic

Authored by benhamilton on Apr 2 2018, 9:13 AM.

Details

Summary

D44816 attempted to fix a few cases where clang-format incorrectly
inserted a space before the closing brace of an Objective-C dictionary
literal.

This revealed there were still a few cases where we inserted a space
after the opening brace of an Objective-C dictionary literal.

This fixes the formatting to be consistent and adds more tests.

Test Plan: New tests added. Confirmed tests failed before

diff and passed after diff.
Ran tests with:
% make -j12 FormatTests && ./tools/clang/unittests/Format/FormatTests

Diff Detail

Repository
rL LLVM

Event Timeline

benhamilton created this revision.Apr 2 2018, 9:13 AM
djasper accepted this revision.Apr 2 2018, 10:23 PM

Looks good.

This revision is now accepted and ready to land.Apr 2 2018, 10:23 PM
This revision was automatically updated to reflect the committed changes.