Paths
| Differential D45123
[CodeView] Emit function options for subprogram and member functions ClosedPublic Authored by asmith on Mar 31 2018, 8:24 AM.
Details Summary Use the newly added DebugInfo (DI) Trivial flag, which indicates if a C++ record is trivial or not, to determine Codeview::FunctionOptions. Clang and MSVC generate slightly different Codeview for C++ records. For example, here is the C++ code for a class with a defaulted ctor, class C {
public:
C() = default;
};Clang will produce a LF for the defaulted ctor while MSVC does not. For more details, refer to FIXMEs in the test cases in "function-options.ll" included with this set of changes.
Diff Detail Event TimelineComment Actions I think we actually want the triviality marker on the DISubprogram, not the DICompositeType. If I understand, this patch will still emit LF_METHOD records for trivial, but user-defaulted constructors, like: struct Foo { Foo() = default; };Comment Actions There's no LF_METHOD generated by Clang. Take a look at C1Class in the included tests which is the same are your example. class C1Class {
public:
C1Class() = default; // FIXME: Clang generates defaulted ctor while MSVC doesn't.
// We won't check what clang yields in this test. (though FO is correct)
};Comment Actions You're right, this patch does get the constructor member LF right, but it would be easier and more direct if the constructor itself were marked trivial or just omitted by clang. Comment Actions It might be best to limit the scope of the patch to just CxxReturnUdt and we can fix the other flags incrementally.
Comment Actions lgtm, thanks!
This revision is now accepted and ready to land.Oct 1 2018, 1:54 PM Closed by commit rL343626: [CodeView] Emit function options for subprogram and member functions (authored by asmith). · Explain WhyOct 2 2018, 1:22 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 167666 lib/CodeGen/AsmPrinter/CodeViewDebug.h
lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
test/DebugInfo/COFF/function-options.ll
test/DebugInfo/COFF/global-type-hashes.ll
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
In the future, you might find llvm-pdbutil dump -types to be a little more FileCheck-friendly. It's more concise, and it works on both object files and PDBs, so you only have to read one dumper format.