This is an archive of the discontinued LLVM Phabricator instance.

Differential D45102

Fix typo in comment -fmath-errno=0 -> -fno-math-errno
ClosedPublic

Authored by sbc100 on Mar 30 2018, 11:53 AM.

Details

Reviewers
• ddunbar
jgravelle-google
Commits
rG5e9059ceb186: Fix typo in comment -fmath-errno=0 -> -fno-math-errno
rC329323: Fix typo in comment -fmath-errno=0 -> -fno-math-errno
rL329323: Fix typo in comment -fmath-errno=0 -> -fno-math-errno
Summary

The former is not a valid clang argument

Diff Detail

Event Timeline

sbc100 created this revision.Mar 30 2018, 11:53 AM
Herald added subscribers: cfe-commits, aheejin. · View Herald TranscriptMar 30 2018, 11:53 AM
Harbormaster completed remote builds in B16596: Diff 140463.Mar 30 2018, 11:53 AM
sbc100 added a reviewer: • ddunbar.Mar 30 2018, 11:55 AM
sbc100 added a reviewer: jgravelle-google.Apr 4 2018, 10:23 AM
jgravelle-google accepted this revision.Apr 4 2018, 10:39 AM
This revision is now accepted and ready to land.Apr 4 2018, 10:39 AM
Closed by commit rL329323: Fix typo in comment -fmath-errno=0 -> -fno-math-errno (authored by sbc). · Explain WhyApr 5 2018, 10:47 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptApr 5 2018, 10:47 AM

Revision Contents

PathSize
include/
clang/
Basic/
2 lines

Diff 140463

include/clang/Basic/Builtins.def

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
// P:N: -> similar to the p:N: attribute, but the function is like vprintf // P:N: -> similar to the p:N: attribute, but the function is like vprintf
// in that it accepts its arguments as a va_list rather than // in that it accepts its arguments as a va_list rather than
// through an ellipsis // through an ellipsis
// s:N: -> this is a scanf-like function whose Nth argument is the format // s:N: -> this is a scanf-like function whose Nth argument is the format
// string. // string.
// S:N: -> similar to the s:N: attribute, but the function is like vscanf // S:N: -> similar to the s:N: attribute, but the function is like vscanf
// in that it accepts its arguments as a va_list rather than // in that it accepts its arguments as a va_list rather than
// through an ellipsis // through an ellipsis
// e -> const, but only when -fmath-errno=0 // e -> const, but only when -fno-math-errno
// j -> returns_twice (like setjmp) // j -> returns_twice (like setjmp)
// u -> arguments are not evaluated for their side-effects // u -> arguments are not evaluated for their side-effects
// FIXME: gcc has nonnull // FIXME: gcc has nonnull
#if defined(BUILTIN) && !defined(LIBBUILTIN) #if defined(BUILTIN) && !defined(LIBBUILTIN)
# define LIBBUILTIN(ID, TYPE, ATTRS, HEADER, BUILTIN_LANG) BUILTIN(ID, TYPE, ATTRS) # define LIBBUILTIN(ID, TYPE, ATTRS, HEADER, BUILTIN_LANG) BUILTIN(ID, TYPE, ATTRS)
#endif #endif
▲ Show 20 Lines • Show All 1,364 Lines • Show Last 20 Lines