This is an archive of the discontinued LLVM Phabricator instance.

Change DEBUG() macro to LLVM_DEBUG()
ClosedPublic

Authored by Nicola on Mar 28 2018, 3:35 AM.

Details

Summary

The DEBUG() macro is too generic so it might clash with other projects.
This is going to be deprecated and replaced by LLVM_DEBUG() as soon as https://reviews.llvm.org/D43624 is submitted.

This is the command I used to do the replacement and formatting:
git grep -l 'DEBUG' | xargs sed -i 's/\bDEBUG\s\?(/LLVM_DEBUG(/g'
git diff -U0 master | ../clang/tools/clang-format/clang-format-diff.py -i -p1 -style LLVM

I avoided replacing the clang-format strings that used DEBUG() as a macro.

Diff Detail

Repository
rL LLVM

Event Timeline

Nicola created this revision.Mar 28 2018, 3:35 AM
Nicola added a comment.Apr 4 2018, 6:34 AM

Ping? I'm not sure who to add as reviewers as it's generic change.

rnk accepted this revision.Apr 10 2018, 10:39 AM

lgtm

This revision is now accepted and ready to land.Apr 10 2018, 10:39 AM
This revision was automatically updated to reflect the committed changes.