It is tedious to allocate and then placement-new the construction context, so i added a tiny variadic template to improve readability.
Also fix more else-after-return thingies.
Paths
| Differential D44725
[CFG] [analyzer] NFC: Move construction context allocation into a helper method. ClosedPublic Authored by NoQ on Mar 20 2018, 7:48 PM.
Details
Summary It is tedious to allocate and then placement-new the construction context, so i added a tiny variadic template to improve readability. Also fix more else-after-return thingies.
Diff Detail
Event TimelineComment Actions I'd rather keep the helper method within the class. This allows us to keep constructors private, which is something i forgot to do originally. Comment Actions LGTM, but would actually make even more sense as a static function for the allocator. This revision is now accepted and ready to land.Mar 21 2018, 4:28 PM Comment Actions
I like your thinking, but that'd require me to make the allocator my friend class (: NoQ added a child revision: D44763: [CFG] [analyzer] Add C++17-specific constructor-initializer construction contexts..Mar 21 2018, 5:11 PM NoQ retitled this revision from [analyzer] NFC: Move construction context allocation into a helper method. to [CFG] [analyzer] NFC: Move construction context allocation into a helper method.. Closed by commit rC328249: [CFG] [analyzer] NFC: Move construction context allocation into a helper method. (authored by NoQ). · Explain WhyMar 22 2018, 2:45 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 139515 include/clang/Analysis/ConstructionContext.h
lib/Analysis/ConstructionContext.cpp
|