This is an archive of the discontinued LLVM Phabricator instance.

[Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin
ClosedPublic

Authored by phosek on Mar 20 2018, 7:27 PM.

Details

Summary

The Clang driver doesn't currently know how to use the libraries
that are shipped as part of the toolchain so there's no reason to
ship them at all.

Diff Detail

Repository
rC Clang

Event Timeline

phosek created this revision.Mar 20 2018, 7:27 PM

When targetting Darwin we should really not be even compiling libc++/libc++abi and certainly should not have anything else compiling against their headers since at runtime the system libraries will be used and so things better compile against the system headers that match.
Do these settings accomplish that?

phosek updated this revision to Diff 139249.Mar 20 2018, 8:43 PM
phosek retitled this revision from [Fuchsia] Avoid using static ABI library with libc++ on Darwin to [Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin.
phosek edited the summary of this revision. (Show Details)

Done, they're no longer installed on Darwin.

mcgrathr accepted this revision.Mar 20 2018, 11:08 PM

Lgtm with some more comments

This revision is now accepted and ready to land.Mar 20 2018, 11:08 PM
phosek updated this revision to Diff 139311.Mar 21 2018, 9:50 AM
This revision was automatically updated to reflect the committed changes.