Page MenuHomePhabricator

[AMDGPU] Define code object identification string used in AMDHSA runtimes.
ClosedPublic

Authored by t-tye on Mar 20 2018, 4:16 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

t-tye created this revision.Mar 20 2018, 4:16 PM
This revision is now accepted and ready to land.Mar 21 2018, 3:48 PM
t-tye updated this revision to Diff 139634.Mar 23 2018, 12:14 PM

Change target feature element of the target identification string to be comma separated so hyphens only delimit the elements.

LGTM, but I'd rather use '+' instead of ',' for the features.

t-tye updated this revision to Diff 139643.Mar 23 2018, 1:03 PM

Change syntax for target features to be concatenated to Processor using a plus prefix for each target feature.

t-tye added a comment.Mar 23 2018, 1:04 PM

LGTM, but I'd rather use '+' instead of ',' for the features.

Changed to use + prefix as suggested by Laurent.

kzhuravl added inline comments.Mar 23 2018, 1:24 PM
docs/AMDGPUUsage.rst
941 ↗(On Diff #139643)

I'd rather have a '-' separator, as it would be easier to tokenize.

This revision was automatically updated to reflect the committed changes.