[test] Add test for version scripts with extern C++ and GNU ABI tags.

[RAOF]

Summary

This is a testcase for https://bugs.llvm.org/show_bug.cgi?id=36777, which is
fixed by https://reviews.llvm.org/D44614.

[grimar]

Having such test case in LLD seems reasonable to me.

test/ELF/linkerscript/cxx11-tag-version.s

3

Please use:
echo 'VER1 { global: extern "C++" { returns_string*; accepts_string*; global* }; local: *; };' > %t.script

24

I do not think you need to check anything except the names here. So I would shorten the checks:

# CHECK: _Z14accepts_stringRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
# CHECK: _Z14returns_stringB5cxx11v
# CHECK: _Z6globalB5cxx11

33

And I would drop the comments, they do not seem to be useful.

[• espindola]

You could use llvm-cxxfilt.cpp to more directly test the demangler, no?

[RAOF]

Updated test case to match review.

[ruiu]

"cxx11-tag-version.s" is not an appropriate file name for this test case because this is not specific to C++11. I'd name "extern-cpp.s".

test/ELF/linkerscript/cxx11-tag-version.s

4

I think you can remove "VER1".

9

Remove extraneous space characters between "CHECK:" and "Name:"

13–26

You don't need to repeat the same test case three times. Please use only one symbol.

test/ELF/linkerscript/cxx11-tag-version.s

+# REQUIRES: x86
+
+# RUN: echo "VER1 { global: extern \"C++\" { returns_string*; accepts_string*; global*}; local: *; } ;" > %t.script
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+# RUN: ld.lld --version-script %t.script -shared %t.o -o %t.so
+# RUN: llvm-readobj -dyn-symbols %t.so | FileCheck %s
+
+# CHECK:      Name: _Z14accepts_stringRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE@@VER1
+# CHECK-NEXT: Value: 0
+# CHECK-NEXT: Size: 0
+# CHECK-NEXT: Binding: Global
+# CHECK-NEXT: Type: Function
+# CHECK-NEXT: Other: 0
+# CHECK-NEXT: Section: .text
+
+# CHECK:      Name: _Z14returns_stringB5cxx11v@@VER1
+# CHECK-NEXT: Value: 0
+# CHECK-NEXT: Size: 0
+# CHECK-NEXT: Binding: Global
+# CHECK-NEXT: Type: Function
+# CHECK-NEXT: Other: 0
+# CHECK-NEXT: Section: .text
+
+# CHECK:      Name: _Z6globalB5cxx11@@VER1
+# CHECK-NEXT: Value: 0
+# CHECK-NEXT: Size: 0
+# CHECK-NEXT: Binding: Global
+# CHECK-NEXT: Type: Object
+# CHECK-NEXT: Other: 0
+# CHECK-NEXT: Section: .bss
+
+.text
+.globl  _Z14returns_stringB5cxx11v # -- Begin function _Z14returns_stringB5cxx11v
+.type _Z14returns_stringB5cxx11v,@function
+_Z14returns_stringB5cxx11v:
+
+.text
+.globl  _Z14accepts_stringRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE # -- Begin function _Z14accepts_stringRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
+.type _Z14accepts_stringRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE,@function
+_Z14accepts_stringRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE: # @_Z14accepts_stringRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
+
+.bss
+.type _Z6globalB5cxx11,@object # @_Z6globalB5cxx11
+.globl  _Z6globalB5cxx11
+_Z6globalB5cxx11:
+