This is an archive of the discontinued LLVM Phabricator instance.

[test] Add test for demangling GNU ABI tags
ClosedPublic

Authored by RAOF on Mar 18 2018, 5:21 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

RAOF created this revision.Mar 18 2018, 5:21 PM
RAOF added a comment.Mar 18 2018, 5:47 PM

I couldn't find test cases for the demangler, but https://reviews.llvm.org/D44615 is the LLD test case that this fixes.

Changes to the demangler should go first to libcxxabi/src/cxa_demangle.cpp.

RAOF added a comment.Mar 19 2018, 11:40 PM

Looks like libcxxabi/src/cxx_demangle.cpp already supports this:

2914: Node *Db::parseAbiTags(Node *N) {

and the associated AbiTagAttr class.

Looks like libcxxabi/src/cxx_demangle.cpp already supports this:

2914: Node *Db::parseAbiTags(Node *N) {

and the associated AbiTagAttr class.

So this was fixed by r327859?

RAOF updated this revision to Diff 139248.Mar 20 2018, 8:42 PM

Added a llvm-cxxfilt test for the demanger changes.

RAOF updated this revision to Diff 139251.Mar 20 2018, 9:53 PM
RAOF retitled this revision from Demangle: Support GNU ABI tag attributes to [test] Add test for demangling GNU ABI tags.
RAOF edited the summary of this revision. (Show Details)

Yes! What timing. This was indeed fixed in r327859.

I've replaced the patch with a testcase verifying that it's fixed instead.

espindola accepted this revision.Mar 21 2018, 8:57 AM

LGTM.
Do you have commit access?

This revision is now accepted and ready to land.Mar 21 2018, 8:57 AM
RAOF added a comment.Mar 21 2018, 6:16 PM

I do not have commit access; could you please commit it?