This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Fix the assertion failure when static globals are used in lambda by reference
ClosedPublic

Authored by george.karpenkov on Mar 16 2018, 5:31 PM.

Diff Detail

Event Timeline

xazax.hun accepted this revision.Mar 17 2018, 2:31 AM

LGTM!

I am only wondering what is the policy regarding the tests? When should we add a new file or when should we just extend an existing one?

This revision is now accepted and ready to land.Mar 17 2018, 2:31 AM

I am only wondering what is the policy regarding the tests?

@xazax.hun I don't think we have any, which is indeed often confusing. Which file did you have in mind?

I was thinking about test/Analysis/lambdas.cpp as a possible candidate.

NoQ accepted this revision.Mar 19 2018, 2:07 PM

I am only wondering what is the policy regarding the tests?

There doesn't seem to be any yet. We often have to create new files when we're disappointed with the run-line(s) of the existing files or want to use global declarations that conflict with those in existing files.

This revision was automatically updated to reflect the committed changes.