This is an archive of the discontinued LLVM Phabricator instance.

Differential D44556

OpenBSD UBsan support final missing bits
ClosedPublic

Authored by devnexen on Mar 16 2018, 4:09 AM.

Details

Reviewers
vitalybuka
vsk
Commits
rGec55b0782458: OpenBSD UBsan support final missing bits
rL327758: OpenBSD UBsan support final missing bits
rCRT327758: OpenBSD UBsan support final missing bits
Summary

One forgotten file change + reordering one header due to clang-format

Patch by David CARLIER

Diff Detail

Event Timeline

devnexen created this revision.Mar 16 2018, 4:09 AM
Herald added subscribers: Restricted Project, llvm-commits, fedor.sergeev, kubamracek. · View Herald TranscriptMar 16 2018, 4:09 AM
devnexen added a comment.Mar 16 2018, 4:10 AM

Sorry appearing obnoxious ... here the last needed changes hopefully. Thanks.

vitalybuka edited the summary of this revision. (Show Details)Mar 16 2018, 2:45 PM
vitalybuka added inline comments.Mar 16 2018, 2:59 PM
lib/sanitizer_common/sanitizer_procmaps_bsd.cc
22

Why do you need this order?

devnexen added inline comments.Mar 16 2018, 3:05 PM
lib/sanitizer_common/sanitizer_procmaps_bsd.cc
22

Because int32_t type needed for sysctl.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2018, 3:32 PM
Closed by commit rCRT327758: OpenBSD UBsan support final missing bits (authored by vitalybuka). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: krytarowski. · View Herald TranscriptMar 16 2018, 3:32 PM
vitalybuka reopened this revision.Mar 16 2018, 4:14 PM
vitalybuka accepted this revision.
This revision is now accepted and ready to land.Mar 16 2018, 4:14 PM
vitalybuka closed this revision.Mar 16 2018, 4:14 PM

Revision Contents

PathSize
lib/
sanitizer_common/
5 lines
2 lines

Diff 138679

lib/sanitizer_common/sanitizer_linux.h

Show All 9 Lines
// Linux-specific syscall wrappers and classes. // Linux-specific syscall wrappers and classes.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef SANITIZER_LINUX_H #ifndef SANITIZER_LINUX_H
#define SANITIZER_LINUX_H #define SANITIZER_LINUX_H
#include "sanitizer_platform.h" #include "sanitizer_platform.h"
#if SANITIZER_FREEBSD || SANITIZER_LINUX || SANITIZER_NETBSD || \ #if SANITIZER_FREEBSD || SANITIZER_LINUX || SANITIZER_NETBSD || \
SANITIZER_SOLARIS SANITIZER_OPENBSD || SANITIZER_SOLARIS
#include "sanitizer_common.h" #include "sanitizer_common.h"
#include "sanitizer_internal_defs.h" #include "sanitizer_internal_defs.h"
#include "sanitizer_platform_limits_netbsd.h" #include "sanitizer_platform_limits_netbsd.h"
#include "sanitizer_platform_limits_openbsd.h"
#include "sanitizer_platform_limits_posix.h" #include "sanitizer_platform_limits_posix.h"
#include "sanitizer_platform_limits_solaris.h" #include "sanitizer_platform_limits_solaris.h"
#include "sanitizer_posix.h" #include "sanitizer_posix.h"
struct link_map; // Opaque type returned by dlopen(). struct link_map; // Opaque type returned by dlopen().
namespace __sanitizer { namespace __sanitizer {
// Dirent structure for getdents(). Note that this structure is different from // Dirent structure for getdents(). Note that this structure is different from
▲ Show 20 Lines • Show All 111 Lines • ▼ Show 20 LinesALWAYS_INLINE uptr *get_android_tls_ptr() {
return reinterpret_cast<uptr *>(&__get_tls()[TLS_SLOT_TSAN]); return reinterpret_cast<uptr *>(&__get_tls()[TLS_SLOT_TSAN]);
} }
#endif // SANITIZER_ANDROID #endif // SANITIZER_ANDROID
} // namespace __sanitizer } // namespace __sanitizer
#endif // SANITIZER_FREEBSD || SANITIZER_LINUX || SANITIZER_NETBSD || #endif // SANITIZER_FREEBSD || SANITIZER_LINUX || SANITIZER_NETBSD ||
// SANITIZER_SOLARIS // SANITIZER_OPENBSD || SANITIZER_SOLARIS
#endif // SANITIZER_LINUX_H #endif // SANITIZER_LINUX_H

lib/sanitizer_common/sanitizer_procmaps_bsd.cc

Show All 13 Lines
#include "sanitizer_platform.h" #include "sanitizer_platform.h"
#if SANITIZER_FREEBSD || SANITIZER_NETBSD || SANITIZER_OPENBSD #if SANITIZER_FREEBSD || SANITIZER_NETBSD || SANITIZER_OPENBSD
#include "sanitizer_common.h" #include "sanitizer_common.h"
#if SANITIZER_FREEBSD #if SANITIZER_FREEBSD
#include "sanitizer_freebsd.h" #include "sanitizer_freebsd.h"
#endif #endif
#include "sanitizer_procmaps.h" #include "sanitizer_procmaps.h"
#include <sys/sysctl.h>
#include <sys/types.h> #include <sys/types.h>
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

Why do you need this order?

vitalybuka: Why do you need this order?
devnexenAuthorUnsubmitted
Not Done
ReplyInline Actions

Because int32_t type needed for sysctl.

devnexen: Because int32_t type needed for sysctl.
#include <sys/sysctl.h>
#include <unistd.h> #include <unistd.h>
#if SANITIZER_FREEBSD #if SANITIZER_FREEBSD
#include <sys/user.h> #include <sys/user.h>
#endif #endif
#include <limits.h> #include <limits.h>
#if SANITIZER_OPENBSD #if SANITIZER_OPENBSD
#define KVME_PROT_READ KVE_PROT_READ #define KVME_PROT_READ KVE_PROT_READ
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines