[dotest] Rename llvm-dotest -> lldb-dotest and make it a custom target

[JDevlieghere]

Summary

This renames llvm-dotest to lldb-dotest and makes it a custom target so
you can run ninja lldb-dotest to rebuild whatever is necessary before
rerunning the tests.

[davide]

LGTM

[zturner]

Shouldn’t it be lldb-dotest? I’m confused about what this target does

[davide]

The name should be changed (also the utility name), but that should be done separately.

[davide]

Also, I second the feeling of having lldb somewhere in the name for the utility (rather than llvm :)

[JDevlieghere]

Yeah, that's more sensible indeed. I must have had llvm-lit in mind and never gave it a second thought.

lldb/trunk/test/CMakeLists.txt

add_python_test_target(check-lldb
   "-q;${LLDB_DOTEST_ARGS}"
   "Testing LLDB (parallel execution, with a separate subprocess per test)"
   )
 
 # Generate a wrapper for dotest.py in the bin directory.
 string (REPLACE ";" " " LLDB_DOTEST_ARGS_STR  "${LLDB_DOTEST_ARGS}")
 # We need this to substitute variables.
 configure_file(
-  llvm-dotest.in
-  ${CMAKE_CURRENT_BINARY_DIR}/llvm-dotest.configured
+  lldb-dotest.in
+  ${CMAKE_CURRENT_BINARY_DIR}/lldb-dotest.configured
   )
 # We need this to expand the generator expressions.
 file(GENERATE
   OUTPUT
-  $<TARGET_FILE_DIR:lldb>/llvm-dotest
+  $<TARGET_FILE_DIR:lldb>/lldb-dotest
   INPUT
-  ${CMAKE_CURRENT_BINARY_DIR}/llvm-dotest.configured
+  ${CMAKE_CURRENT_BINARY_DIR}/lldb-dotest.configured
   )
+# Make this a custom target.
+add_custom_target(lldb-dotest)
+add_dependencies(lldb-dotest ${LLDB_TEST_DEPS})
 
 # If we're building with an in-tree clang, then list clang as a dependency
 # to run tests.
 if (TARGET clang)
   add_dependencies(check-lldb clang)
 endif()
 
 # LLD is required to link test executables on Windows.

lldb/trunk/test/lldb-dotest.in

+#!/usr/bin/env python
+import sys
+import os
+
+dotest_path = '@LLDB_SOURCE_DIR@/test/dotest.py'
+dotest_args = '@LLDB_DOTEST_ARGS_STR@'
+
+if __name__ == '__main__':
+    # FIXME: It would be nice if we can mimic the approach taken by llvm-lit
+    # and pass a python configuration straight to dotest, rather than going
+    # through the operating system.
+    command = '{} -q {} {}'.format(dotest_path, dotest_args, ' '.join(
+        sys.argv[1:]))
+    os.system(command)

lldb/trunk/test/llvm-dotest.in

-#!/usr/bin/env python
-import sys
-import os
-
-dotest_path = '@LLDB_SOURCE_DIR@/test/dotest.py'
-dotest_args = '@LLDB_DOTEST_ARGS_STR@'
-
-if __name__ == '__main__':
-    # FIXME: It would be nice if we can mimic the approach taken by llvm-lit
-    # and pass a python configuration straight to dotest, rather than going
-    # through the operating system.
-    command = '{} -q {} {}'.format(dotest_path, dotest_args, ' '.join(
-        sys.argv[1:]))
-    os.system(command)