This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Don't expose vfs in TUScheduler::runWithPreamble.
ClosedPublic

Authored by ilya-biryukov on Mar 14 2018, 5:04 AM.

Event Timeline

ilya-biryukov created this revision.Mar 14 2018, 5:04 AM
sammccall accepted this revision.Mar 14 2018, 6:56 AM
sammccall added inline comments.
clangd/TUScheduler.h
94

I think this is the right place to describe the way FS interaction works (which implies why we don't propagate vfs):

/// The preamble may be stale, generated from an older version of the file.
/// Reading from locations in the preamble may cause the files to be re-read.
/// This gives callers two options:
/// - validate that the preamble is still valid, and only use it in this case
/// - accept that preamble contents may be outdated, and try to avoid reading source code from headers.
This revision is now accepted and ready to land.Mar 14 2018, 6:56 AM
  • Rebase on top of master
  • Add the suggested comment
ilya-biryukov marked an inline comment as done.Mar 14 2018, 10:47 AM
This revision was automatically updated to reflect the committed changes.