Page MenuHomePhabricator

[clangd] Don't index template specializations.
ClosedPublic

Authored by sammccall on Mar 9 2018, 5:01 AM.

Details

Summary

These have different USRs than the underlying entity, but are not typically
interesting in their own right and can be numerous (e.g. generated traits).

Diff Detail

Repository
rL LLVM

Event Timeline

sammccall created this revision.Mar 9 2018, 5:01 AM
sammccall updated this revision to Diff 137729.Mar 9 2018, 5:01 AM

merge matchers

sammccall updated this revision to Diff 137731.Mar 9 2018, 5:16 AM

verify that we don't emit extra symbols in other template-related cases

ioeric accepted this revision.Mar 9 2018, 5:16 AM

lgtm

unittests/clangd/SymbolCollectorTests.cpp
200 ↗(On Diff #137729)

nit: I'd probably also check the range, just in case...

This revision is now accepted and ready to land.Mar 9 2018, 5:16 AM
sammccall marked an inline comment as done.Mar 9 2018, 5:27 AM
This revision was automatically updated to reflect the committed changes.