Page MenuHomePhabricator

[clangd] Fix diagnostic errors in the test code, NFC.
ClosedPublic

Authored by hokein on Mar 9 2018, 2:12 AM.

Event Timeline

hokein created this revision.Mar 9 2018, 2:12 AM
ilya-biryukov added inline comments.Mar 9 2018, 2:19 AM
unittests/clangd/XRefsTests.cpp
587

I would go with #pragma once in the test code, it adds less noise. WDYT?

hokein updated this revision to Diff 137712.Mar 9 2018, 2:54 AM
hokein marked an inline comment as done.

Use #program once

unittests/clangd/XRefsTests.cpp
587

I thought #pragma once is non-standard, but the diagnostic message also suggest this fix. Changed to it.

ilya-biryukov accepted this revision.Mar 12 2018, 7:47 AM
ilya-biryukov added inline comments.
unittests/clangd/XRefsTests.cpp
587

Thanks! It's non-standard, but supported on every modern compiler, so we should be fine :-)

This revision is now accepted and ready to land.Mar 12 2018, 7:47 AM
This revision was automatically updated to reflect the committed changes.