Page MenuHomePhabricator

[analyzer] Move the GCDAsyncSemaphoreChecker to optin.performance
ClosedPublic

Authored by george.karpenkov on Mar 7 2018, 2:40 PM.

Diff Detail

Repository
rC Clang

Event Timeline

I put some post-commit comments in https://reviews.llvm.org/D44059 about diagnostic text and naming that you should address as part of graduating this out of alpha.

@dcoughlin Integrated post-commit feedback.

dcoughlin accepted this revision.Mar 9 2018, 2:48 PM

LGTM, but I do think Artem is right that we should push the user in the right direction here. There is a suggested addendum inline.

lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp
156

I agree with Artem that we should push the user in the right direction here. Let's add "; consider using a synchronous API or changing the caller to be asynchronous" to the description.

This revision is now accepted and ready to land.Mar 9 2018, 2:48 PM
This revision was automatically updated to reflect the committed changes.