This is an archive of the discontinued LLVM Phabricator instance.

[dwarfdump] Only print offset in verbose mode
ClosedPublic

Authored by JDevlieghere on Mar 6 2018, 6:22 AM.

Details

Summary

Instead of only printing the offset in non-verbose mode, it makes more
sense to only printed the resolved address. In verbose mode we still
print both.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Mar 6 2018, 6:22 AM

So non-verbose shows the section-relative offset instead of the CU-relative offset. That seems reasonable.
You might give Adrian and David another day to complain, but LGTM.

aprantl accepted this revision.Mar 7 2018, 8:17 AM

You might give Adrian and David another day to complain

I was the one who asked for this feature :-)

This revision is now accepted and ready to land.Mar 7 2018, 8:17 AM
This revision was automatically updated to reflect the committed changes.