This is an archive of the discontinued LLVM Phabricator instance.

Differential D44068

OpenBSD sanitizer common, define RLIMIT_AS constant
ClosedPublic

Authored by devnexen on Mar 3 2018, 4:20 AM.

Details

Reviewers
krytarowski
vitalybuka
Commits
rG2f358738b874: OpenBSD sanitizer common, define RLIMIT_AS constant
rCRT326768: OpenBSD sanitizer common, define RLIMIT_AS constant
rL326768: OpenBSD sanitizer common, define RLIMIT_AS constant
Summary

define RLIMIT_AS constant until it s defined in the future

Diff Detail

Event Timeline

devnexen created this revision.Mar 3 2018, 4:20 AM
Herald added subscribers: Restricted Project, llvm-commits, kubamracek. · View Herald TranscriptMar 3 2018, 4:20 AM
krytarowski added inline comments.Mar 3 2018, 4:39 AM
lib/sanitizer_common/sanitizer_platform_limits_openbsd.h
34

Do we need this check?

devnexen added inline comments.Mar 3 2018, 4:41 AM
lib/sanitizer_common/sanitizer_platform_limits_openbsd.h
34

Not necessarily for now but might depend on future OpenBSD versions.

krytarowski added a comment.Mar 3 2018, 7:00 AM

Knowing OpenBSD, their goal is no compatibility with others.

lib/sanitizer_common/sanitizer_platform_limits_openbsd.h
34

I see no point in supporting hypothetical OpenBSD versions that are not there, especially since OpenBSD is known going its own route.

devnexen updated this revision to Diff 136920.Mar 3 2018, 7:04 AM
vitalybuka accepted this revision.Mar 3 2018, 5:24 PM
This revision is now accepted and ready to land.Mar 3 2018, 5:24 PM
Closed by commit rL326768: OpenBSD sanitizer common, define RLIMIT_AS constant (authored by kamil). · Explain WhyMar 6 2018, 12:26 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: delcypher. · View Herald TranscriptMar 6 2018, 12:26 AM

Revision Contents

PathSize
lib/
sanitizer_common/
2 lines

Diff 136920

lib/sanitizer_common/sanitizer_platform_limits_openbsd.h

Show All 25 Lines
#if defined(__x86_64__) #if defined(__x86_64__)
#define GET_LINK_MAP_BY_DLOPEN_HANDLE(handle) \ #define GET_LINK_MAP_BY_DLOPEN_HANDLE(handle) \
_GET_LINK_MAP_BY_DLOPEN_HANDLE(handle, 312) _GET_LINK_MAP_BY_DLOPEN_HANDLE(handle, 312)
#elif defined(__i386__) #elif defined(__i386__)
#define GET_LINK_MAP_BY_DLOPEN_HANDLE(handle) \ #define GET_LINK_MAP_BY_DLOPEN_HANDLE(handle) \
_GET_LINK_MAP_BY_DLOPEN_HANDLE(handle, 164) _GET_LINK_MAP_BY_DLOPEN_HANDLE(handle, 164)
#endif #endif
#define RLIMIT_AS RLIMIT_DATA
krytarowskiUnsubmitted
Not Done
ReplyInline Actions

Do we need this check?

krytarowski: Do we need this check?
devnexenAuthorUnsubmitted
Not Done
ReplyInline Actions

Not necessarily for now but might depend on future OpenBSD versions.

devnexen: Not necessarily for now but might depend on future OpenBSD versions.
krytarowskiUnsubmitted
Not Done
ReplyInline Actions

I see no point in supporting hypothetical OpenBSD versions that are not there, especially since OpenBSD is known going its own route.

krytarowski: I see no point in supporting hypothetical OpenBSD versions that are not there, especially since…
namespace __sanitizer { namespace __sanitizer {
extern unsigned struct_utsname_sz; extern unsigned struct_utsname_sz;
extern unsigned struct_stat_sz; extern unsigned struct_stat_sz;
extern unsigned struct_rusage_sz; extern unsigned struct_rusage_sz;
extern unsigned siginfo_t_sz; extern unsigned siginfo_t_sz;
extern unsigned struct_itimerval_sz; extern unsigned struct_itimerval_sz;
extern unsigned pthread_t_sz; extern unsigned pthread_t_sz;
extern unsigned pthread_mutex_t_sz; extern unsigned pthread_mutex_t_sz;
▲ Show 20 Lines • Show All 339 Lines • Show Last 20 Lines