This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Fix "code unreachable" warning in DNBArchImplX86_64::SetRegisterValue
AcceptedPublic

Authored by kubamracek on Mar 2 2018, 4:54 PM.

Reviewers

Summary

Looks like an actual bug and a result of a bag merge.

This revision is now accepted and ready to land.Mar 2 2018, 5:44 PM

This seems scary. We really need a test case for this.

In D44058#1026646, @davide wrote:

This seems scary. We really need a test case for this.

Agreed, but I don't know this code, so I'm not able to come up with a test for this.

Path

Size

tools/

debugserver/

source/

MacOSX/

x86_64/

2 lines

Show First 20 Lines • Show All 1,911 Lines • ▼ Show 20 Lines	bool DNBArchImplX86_64::SetRegisterValue(uint32_t set, uint32_t reg,
if (regInfo) {		if (regInfo) {
switch (set) {		switch (set) {
case e_regSetGPR:		case e_regSetGPR:
if (reg < k_num_gpr_registers) {		if (reg < k_num_gpr_registers) {
((uint64_t *)(&m_state.context.gpr))[reg] = value->value.uint64;		((uint64_t *)(&m_state.context.gpr))[reg] = value->value.uint64;
success = true;		success = true;
}		}
break;		break;
		case e_regSetFPU:
if (reg > fpu_xmm15 && !(CPUHasAVX() \|\| FORCE_AVX_REGS))		if (reg > fpu_xmm15 && !(CPUHasAVX() \|\| FORCE_AVX_REGS))
return false;		return false;
case e_regSetFPU:
switch (reg) {		switch (reg) {
case fpu_fcw:		case fpu_fcw:
((uint16_t )(&m_state.context.fpu.no_avx.__fpu_fcw)) =		((uint16_t )(&m_state.context.fpu.no_avx.__fpu_fcw)) =
value->value.uint16;		value->value.uint16;
success = true;		success = true;
break;		break;
case fpu_fsw:		case fpu_fsw:
((uint16_t )(&m_state.context.fpu.no_avx.__fpu_fsw)) =		((uint16_t )(&m_state.context.fpu.no_avx.__fpu_fsw)) =
▲ Show 20 Lines • Show All 398 Lines • Show Last 20 Lines