This is an archive of the discontinued LLVM Phabricator instance.

Differential D44044

[analyzer] Don't throw NSNumberObjectConversion warning on object initialization in if-expression
ClosedPublic

Authored by george.karpenkov on Mar 2 2018, 1:30 PM.

Details

Reviewers
dcoughlin
NoQ
Commits
rG8dad0e6cce24: [analyzer] Don't throw NSNumberObjectConversion warning on object…
rC326619: [analyzer] Don't throw NSNumberObjectConversion warning on object…
rL326619: [analyzer] Don't throw NSNumberObjectConversion warning on object…
Summary
if (NSNumber* x = ...)

is a reasonable pattern in objc++, we should not warn on it.

rdar://35152234

Diff Detail

Repository
rC Clang

Event Timeline

george.karpenkov created this revision.Mar 2 2018, 1:30 PM
Herald added subscribers: a.sidorin, szepet, xazax.hun. · View Herald TranscriptMar 2 2018, 1:30 PM
NoQ accepted this revision.Mar 2 2018, 1:33 PM

Makes sense!

This revision is now accepted and ready to land.Mar 2 2018, 1:33 PM
Closed by commit rL326619: [analyzer] Don't throw NSNumberObjectConversion warning on object… (authored by george.karpenkov). · Explain WhyMar 2 2018, 1:39 PM
Closed by commit rC326619: [analyzer] Don't throw NSNumberObjectConversion warning on object… (authored by george.karpenkov). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptMar 2 2018, 1:39 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
lib/
StaticAnalyzer/
Checkers/
6 lines
test/
Analysis/
13 lines

Diff 136842

lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp

Show First 20 Lines • Show All 264 Lines • ▼ Show 20 Lines auto SuspiciousScalarExprM =
expr(ignoringParenImpCasts(expr(hasType(SuspiciousScalarTypeM)))); expr(ignoringParenImpCasts(expr(hasType(SuspiciousScalarTypeM))));
auto ConversionThroughAssignmentM = auto ConversionThroughAssignmentM =
binaryOperator(allOf(hasOperatorName("="), binaryOperator(allOf(hasOperatorName("="),
hasLHS(SuspiciousScalarExprM), hasLHS(SuspiciousScalarExprM),
hasRHS(SuspiciousNumberObjectExprM))); hasRHS(SuspiciousNumberObjectExprM)));
auto ConversionThroughBranchingM = auto ConversionThroughBranchingM =
ifStmt(hasCondition(SuspiciousNumberObjectExprM)) ifStmt(allOf(
.bind("pedantic"); hasCondition(SuspiciousNumberObjectExprM),
unless(hasConditionVariableStatement(declStmt())
))).bind("pedantic");
auto ConversionThroughCallM = auto ConversionThroughCallM =
callExpr(hasAnyArgument(allOf(hasType(SuspiciousScalarTypeM), callExpr(hasAnyArgument(allOf(hasType(SuspiciousScalarTypeM),
ignoringParenImpCasts( ignoringParenImpCasts(
SuspiciousNumberObjectExprM)))); SuspiciousNumberObjectExprM))));
// We bind "check_if_null" to modify the warning message // We bind "check_if_null" to modify the warning message
// in case it was intended to compare a pointer to 0 with a relatively-ok // in case it was intended to compare a pointer to 0 with a relatively-ok
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines

test/Analysis/number-object-conversion.mm

// RUN: %clang_analyze_cc1 -triple i386-apple-darwin10 -fblocks -fobjc-arc -w -analyzer-checker=osx.NumberObjectConversion -analyzer-config osx.NumberObjectConversion:Pedantic=true %s -verify
#include "Inputs/system-header-simulator-objc.h"
NSNumber* generateNumber();
// expected-no-diagnostics
int test_initialization_in_ifstmt() { // Don't warn on initialization in guard.
if (NSNumber* number = generateNumber()) { // no-warning
return 0;
}
return 1;
}