Page MenuHomePhabricator

[WebAssembly] Add assertion for init function signature
ClosedPublic

Authored by ncw on Mar 1 2018, 9:03 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

ncw created this revision.Mar 1 2018, 9:03 AM
sbc100 accepted this revision.Mar 1 2018, 9:12 AM

Nice!

Can you update the title? (this is adding validation, not an assertion).

And I don't think you need to mention other change which it used to be part of (at least not in the description that lands in svn).

This revision is now accepted and ready to land.Mar 1 2018, 9:12 AM
ruiu added inline comments.Mar 1 2018, 9:25 AM
wasm/Writer.cpp
899 ↗(On Diff #136543)

... init func: " + toString(Sym)

This revision was automatically updated to reflect the committed changes.
ncw marked an inline comment as done.Mar 2 2018, 6:49 AM
ncw added inline comments.
wasm/Writer.cpp
899 ↗(On Diff #136543)

Fixed.