This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Clean up old address space mapping and fix constant address space value
ClosedPublic

Authored by yaxunl on Feb 28 2018, 2:13 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

yaxunl created this revision.Feb 28 2018, 2:13 PM

Looks fine to me.

t-tye accepted this revision.Mar 2 2018, 3:25 PM

LGTM except minor comment.

lib/Basic/Targets/AMDGPU.cpp
41–49 ↗(On Diff #136394)

Could the values be the AddrSpace enumerators?

53–61 ↗(On Diff #136394)

Could the values be the AddrSpace enumerators?

254 ↗(On Diff #136394)

To be consistent should this be:

!isAMDGCN(getTriple())
This revision is now accepted and ready to land.Mar 2 2018, 3:25 PM
yaxunl added a comment.Mar 5 2018, 9:35 AM

Will make recommended changes when committing.

This revision was automatically updated to reflect the committed changes.