This is an archive of the discontinued LLVM Phabricator instance.

Differential D43894

OpenBSD UBsan support / ubsan part
ClosedPublic

Authored by devnexen on Feb 28 2018, 12:50 PM.

Details

Reviewers
krytarowski
kettenis
visa
vitalybuka
Commits
rG4410bbc9ed56: OpenBSD UBsan support / ubsan part
rCRT326543: OpenBSD UBsan support / ubsan part
rL326543: OpenBSD UBsan support / ubsan part
Summary

UBsan, enable OpenBSD platform

Diff Detail

Event Timeline

devnexen created this revision.Feb 28 2018, 12:50 PM
Herald added subscribers: Restricted Project, llvm-commits, fedor.sergeev, kubamracek. · View Herald TranscriptFeb 28 2018, 12:50 PM
krytarowski added inline comments.Feb 28 2018, 10:41 PM
lib/ubsan/ubsan_init.cc
43

Rationale?

devnexen updated this revision to Diff 136476.Mar 1 2018, 1:45 AM
vitalybuka accepted this revision.Mar 1 2018, 11:49 AM
This revision is now accepted and ready to land.Mar 1 2018, 11:49 AM
devnexen retitled this revision from [2/3] OpenBSD UBsan support / ubsan part to OpenBSD UBsan support / ubsan part.Mar 1 2018, 11:54 AM
devnexen edited the summary of this revision. (Show Details)
krytarowski added inline comments.Mar 1 2018, 12:49 PM
lib/ubsan/ubsan_platform.h
19

This line is too long and it will be rejected by tests.

devnexen updated this revision to Diff 136591.Mar 1 2018, 12:59 PM
Closed by commit rL326543: OpenBSD UBsan support / ubsan part (authored by kamil). · Explain WhyMar 1 2018, 11:32 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: delcypher. · View Herald TranscriptMar 1 2018, 11:32 PM

Revision Contents

PathSize
lib/
ubsan/
2 lines
4 lines

Diff 136366

lib/ubsan/ubsan_init.cc

Show All 34 Lines
} }
static void CommonStandaloneInit() { static void CommonStandaloneInit() {
SanitizerToolName = GetSanititizerToolName(); SanitizerToolName = GetSanititizerToolName();
CacheBinaryName(); CacheBinaryName();
InitializeFlags(); InitializeFlags();
__sanitizer_set_report_path(common_flags()->log_path); __sanitizer_set_report_path(common_flags()->log_path);
AndroidLogInit(); AndroidLogInit();
#if !SANITIZER_OPENBSD
krytarowskiUnsubmitted
Not Done
ReplyInline Actions

Rationale?

krytarowski: Rationale?
InitializeCoverage(common_flags()->coverage, common_flags()->coverage_dir); InitializeCoverage(common_flags()->coverage, common_flags()->coverage_dir);
#endif
CommonInit(); CommonInit();
} }
void __ubsan::InitAsStandalone() { void __ubsan::InitAsStandalone() {
SpinMutexLock l(&ubsan_init_mu); SpinMutexLock l(&ubsan_init_mu);
if (!ubsan_initialized) { if (!ubsan_initialized) {
CommonStandaloneInit(); CommonStandaloneInit();
ubsan_initialized = true; ubsan_initialized = true;
Show All 14 Lines

lib/ubsan/ubsan_platform.h

Show All 9 Lines
// Defines the platforms which UBSan is supported at. // Defines the platforms which UBSan is supported at.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef UBSAN_PLATFORM_H #ifndef UBSAN_PLATFORM_H
#define UBSAN_PLATFORM_H #define UBSAN_PLATFORM_H
// Other platforms should be easy to add, and probably work as-is. // Other platforms should be easy to add, and probably work as-is.
#if defined(__linux__) || defined(__FreeBSD__) || defined(__APPLE__) || \ #if defined(__linux__) || defined(__FreeBSD__) || defined(__APPLE__) || \
defined(__NetBSD__) || (defined(__sun__) && defined(__svr4__)) || \ defined(__NetBSD__) || defined(__OpenBSD__) || \
defined(_WIN32) || defined(__Fuchsia__) (defined(__sun__) && defined(__svr4__)) || defined(_WIN32) || defined(__Fuchsia__)
krytarowskiUnsubmitted
Not Done
ReplyInline Actions

This line is too long and it will be rejected by tests.

krytarowski: This line is too long and it will be rejected by tests.
# define CAN_SANITIZE_UB 1 # define CAN_SANITIZE_UB 1
#else #else
# define CAN_SANITIZE_UB 0 # define CAN_SANITIZE_UB 0
#endif #endif
#endif #endif