This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: IRTranslate llvm.fabs.* intrinsic
ClosedPublic

Authored by volkan on Feb 28 2018, 3:35 AM.

Details

Summary

Fabs is a common floating-point operation, especially for some expansions. This patch adds
a new generic opcode for llvm.fabs.* intrinsic in order to avoid building/matching this intrinsic.

Diff Detail

Event Timeline

volkan created this revision.Feb 28 2018, 3:35 AM

This looks mostly fine. Could you also add pattern matchers for fabs when you get the greenlight from others?

volkan added a comment.Mar 2 2018, 5:14 AM

This looks mostly fine. Could you also add pattern matchers for fabs when you get the greenlight from others?

Sure, I'll update the patch.

volkan updated this revision to Diff 137048.Mar 5 2018, 11:52 AM

Added pattern matcher support for G_FABS.

aditya_nandakumar accepted this revision.Mar 5 2018, 2:33 PM
This revision is now accepted and ready to land.Mar 5 2018, 2:33 PM
This revision was automatically updated to reflect the committed changes.