This is an archive of the discontinued LLVM Phabricator instance.

Differential D43846

[WebAssembly] Add test for `--undefined` flag. NFC.
ClosedPublic

Authored by sbc100 on Feb 27 2018, 5:24 PM.

Details

Reviewers
ruiu
Commits
rG42cf40b4c586: [WebAssembly] Add test for `--undefined` flag. NFC.
rL326294: [WebAssembly] Add test for `--undefined` flag. NFC.
rLLD326294: [WebAssembly] Add test for `--undefined` flag. NFC.
Summary

Specifically the case where the undefined symbol is not found
during the link.

Diff Detail

Event Timeline

sbc100 created this revision.Feb 27 2018, 5:24 PM
Herald added subscribers: llvm-commits, sunfish, aheejin and 3 others. · View Herald TranscriptFeb 27 2018, 5:24 PM
sbc100 added a reviewer: ruiu.Feb 27 2018, 5:24 PM
Harbormaster completed remote builds in B15496: Diff 136205.Feb 27 2018, 5:25 PM
ruiu accepted this revision.Feb 27 2018, 5:30 PM

LGTM

This revision is now accepted and ready to land.Feb 27 2018, 5:30 PM
Closed by commit rLLD326294: [WebAssembly] Add test for `--undefined` flag. NFC. (authored by sbc). · Explain WhyFeb 27 2018, 5:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
wasm/
5 lines

Diff 136205

test/wasm/undefined.ll

; RUN: llc -filetype=obj %s -o %t.o ; RUN: llc -filetype=obj %s -o %t.o
; RUN: wasm-ld --check-signatures --allow-undefined -o %t.wasm %t.o ; RUN: wasm-ld --check-signatures --allow-undefined -o %t.wasm %t.o
; Fails due to undefined 'foo' ; Fails due to undefined 'foo' and also 'baz'
; RUN: not wasm-ld --check-signatures -o %t.wasm %t.o 2>&1 | FileCheck %s ; RUN: not wasm-ld --check-signatures --undefined=baz -o %t.wasm %t.o 2>&1 | FileCheck %s
; CHECK: error: {{.*}}.o: undefined symbol: foo ; CHECK: error: {{.*}}.o: undefined symbol: foo
; CHECK: error: undefined symbol: baz
; But succeeds if we pass a file containing 'foo' as --allow-undefined-file. ; But succeeds if we pass a file containing 'foo' as --allow-undefined-file.
; RUN: echo 'foo' > %t.txt ; RUN: echo 'foo' > %t.txt
; RUN: wasm-ld --check-signatures --allow-undefined-file=%t.txt -o %t.wasm %t.o ; RUN: wasm-ld --check-signatures --allow-undefined-file=%t.txt -o %t.wasm %t.o
target triple = "wasm32-unknown-unknown-wasm" target triple = "wasm32-unknown-unknown-wasm"
; Takes the address of the external foo() resulting in undefined external ; Takes the address of the external foo() resulting in undefined external
@bar = hidden local_unnamed_addr global i8* bitcast (i32 ()* @foo to i8*), align 4 @bar = hidden local_unnamed_addr global i8* bitcast (i32 ()* @foo to i8*), align 4
declare i32 @foo() #0 declare i32 @foo() #0
define hidden void @_start() local_unnamed_addr #0 { define hidden void @_start() local_unnamed_addr #0 {
entry: entry:
ret void ret void
} }