This is an archive of the discontinued LLVM Phabricator instance.

[GISel]: Print useful remarks when GISelAbort = 1
ClosedPublic

Authored by aditya_nandakumar on Feb 26 2018, 5:16 PM.

Details

Summary

Currently when abort is enabled, we get a diagnostic saying "Fallback path used .... " and the program terminates. To actually figure out what the reason is, we need to run again with another verbose argument "-pass-remarks-missed=gisel".
Because we know we're going to call report_fatal_error(), this patch prints the reason for fallback and this is a lot more useful than the warning diagnostic above. Also, this won't really be a compile time issue.

Diff Detail

Repository
rL LLVM

Event Timeline

aemerson accepted this revision.Feb 27 2018, 5:33 AM

Seems reasonable.

This revision is now accepted and ready to land.Feb 27 2018, 5:33 AM

Thanks. r326215