This is an archive of the discontinued LLVM Phabricator instance.

Differential D43707

[WebAssembly] Add except_ref as a first-class type
ClosedPublic

Authored by aheejin on Feb 23 2018, 5:53 PM.

Details

Reviewers
sbc100
Commits
rG2dce27d852ac: [WebAssembly] Add except_ref as a first-class type
rL326986: [WebAssembly] Add except_ref as a first-class type
rLLD326986: [WebAssembly] Add except_ref as a first-class type
Summary

Add except_ref as a first-class type, according to the Level 1 exception handling proposal.
Companion to D43706.

Diff Detail

Event Timeline

aheejin created this revision.Feb 23 2018, 5:53 PM
Herald added subscribers: llvm-commits, sunfish, jgravelle-google and 2 others. · View Herald TranscriptFeb 23 2018, 5:53 PM
aheejin added a parent revision: D43706: [WebAssembly] Add except_ref as a first-class type.Feb 23 2018, 5:53 PM
aheejin updated this revision to Diff 135824.Feb 25 2018, 6:43 AM

rebase

Harbormaster completed remote builds in B15416: Diff 135824.Feb 25 2018, 6:44 AM
sbc100 accepted this revision.Feb 27 2018, 10:52 AM
This revision is now accepted and ready to land.Feb 27 2018, 10:52 AM
Closed by commit rLLD326986: [WebAssembly] Add except_ref as a first-class type (authored by aheejin). · Explain WhyMar 7 2018, 8:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
wasm/
2 lines

Diff 135749

wasm/WriterUtils.cpp

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Linesstd::string lld::toString(ValType Type) {
case ValType::I32: case ValType::I32:
return "I32"; return "I32";
case ValType::I64: case ValType::I64:
return "I64"; return "I64";
case ValType::F32: case ValType::F32:
return "F32"; return "F32";
case ValType::F64: case ValType::F64:
return "F64"; return "F64";
case ValType::EXCEPT_REF:
return "except_ref";
} }
llvm_unreachable("Invalid wasm::ValType"); llvm_unreachable("Invalid wasm::ValType");
} }
std::string lld::toString(const WasmSignature &Sig) { std::string lld::toString(const WasmSignature &Sig) {
SmallString<128> S("("); SmallString<128> S("(");
for (uint32_t Type : Sig.ParamTypes) { for (uint32_t Type : Sig.ParamTypes) {
if (S.size() != 1) if (S.size() != 1)
Show All 17 Lines