Page MenuHomePhabricator

[WebAssembly] Reorder symbols in table to match MC order
ClosedPublic

Authored by ncw on Feb 23 2018, 10:17 AM.

Details

Summary

This fixes a TODO about symbol ordering.

Previously, the Wasm symbol order was different to the MC order, because of the way symbols were encoded in imports/exports.

Now that we have a symbol table, the Wasm symbol table can match the ordering of iterating over MCAssembler::symbols(); this is the most "canonical" order we can use to keep the tests stable.

Diff Detail

Repository
rL LLVM

Event Timeline

ncw created this revision.Feb 23 2018, 10:17 AM
sbc100 accepted this revision.Feb 27 2018, 12:53 PM

Nice!

"symbols in table" to just "symbol table" in the title maybe?

This revision is now accepted and ready to land.Feb 27 2018, 12:53 PM
This revision was automatically updated to reflect the committed changes.