This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Add comment for preemptible and fix typo. NFC
ClosedPublic

Authored by MaskRay on Feb 22 2018, 12:24 PM.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

MaskRay created this revision.Feb 22 2018, 12:24 PM
MaskRay updated this revision to Diff 135505.Feb 22 2018, 12:45 PM

repeated word typo

This revision was not accepted when it landed; it landed in state Needs Review.Feb 22 2018, 6:07 PM
This revision was automatically updated to reflect the committed changes.
ruiu added a subscriber: ruiu.Feb 22 2018, 6:10 PM
ruiu added inline comments.
ELF/Symbols.h
157

Is this correct? I thought IsPreemptible=true means the symbol is preemptible at load time. I don't think "a symbol preemptible at link time" is a well defined concept.

MaskRay marked an inline comment as done.Feb 23 2018, 2:01 PM
MaskRay added inline comments.
ELF/Symbols.h
157

Fixed in the latest commit. I did not know that I can commit when this revision was in the "Need review" status. I saw a LGTM on my phone.