This is an archive of the discontinued LLVM Phabricator instance.

rongjiecomputer retitled this revision from "Fix CMake/MSVC when compiler-rt and llvm are built separately" to Fix CMake/MSVC when compiler-rt and llvm are built separately.Feb 19 2018, 5:53 AM

lgtm

This revision is now accepted and ready to land.Mar 2 2018, 1:40 PM

Ping after getting LGTM 2 weeks ago.

vitalybuka accepted this revision.Mar 19 2018, 11:24 AM

vitalybuka edited the summary of this revision. (Show Details)

vitalybuka edited reviewers, added: vitalybuka; removed: samsonov.

Closed by commit rL327876: Fix CMake/MSVC when compiler-rt and llvm are built separately (authored by vitalybuka). · Explain WhyMar 19 2018, 11:25 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: delcypher. · View Herald TranscriptMar 19 2018, 11:25 AM

Revision Contents

Path

Size

compiler-rt/

trunk/

CMakeLists.txt

2 lines

Diff 138968

compiler-rt/trunk/CMakeLists.txt

	Show First 20 Lines • Show All 333 Lines • ▼ Show 20 Lines
	if (CMAKE_LINKER MATCHES "link.exe$")			if (CMAKE_LINKER MATCHES "link.exe$")
	# Silence MSVC linker warnings caused by empty object files. The			# Silence MSVC linker warnings caused by empty object files. The
	# sanitizer libraries intentionally use ifdefs that result in empty			# sanitizer libraries intentionally use ifdefs that result in empty
	# files, rather than skipping these files in the build system.			# files, rather than skipping these files in the build system.
	# Ideally, we would pass this flag only for the libraries that need			# Ideally, we would pass this flag only for the libraries that need
	# it, but CMake doesn't seem to have a way to set linker flags for			# it, but CMake doesn't seem to have a way to set linker flags for
	# individual static libraries, so we enable the suppression flag for			# individual static libraries, so we enable the suppression flag for
	# the whole compiler-rt project.			# the whole compiler-rt project.
	append("/IGNORE:4221" CMAKE_STATIC_LINKER_FLAGS)			set(CMAKE_STATIC_LINKER_FLAGS "${CMAKE_STATIC_LINKER_FLAGS} /IGNORE:4221")
	endif()			endif()

	add_subdirectory(include)			add_subdirectory(include)

	foreach(path IN ITEMS ${LLVM_MAIN_SRC_DIR}/projects/libcxx			foreach(path IN ITEMS ${LLVM_MAIN_SRC_DIR}/projects/libcxx
	${LLVM_MAIN_SRC_DIR}/runtimes/libcxx			${LLVM_MAIN_SRC_DIR}/runtimes/libcxx
	${LLVM_MAIN_SRC_DIR}/../libcxx			${LLVM_MAIN_SRC_DIR}/../libcxx
	${LLVM_EXTERNAL_LIBCXX_SOURCE_DIR})			${LLVM_EXTERNAL_LIBCXX_SOURCE_DIR})
	Show All 36 Lines

This is an archive of the discontinued LLVM Phabricator instance.

Fix CMake/MSVC when compiler-rt and llvm are built separatelyClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 138968

compiler-rt/trunk/CMakeLists.txt

Fix CMake/MSVC when compiler-rt and llvm are built separately
ClosedPublic