This is an archive of the discontinued LLVM Phabricator instance.

Differential D43455

[clangd] Add brief instructions on how to make a release for vscode-clangd extension.
ClosedPublic

Authored by hokein on Feb 19 2018, 3:19 AM.

Details

Reviewers
sammccall
Commits
rG359406fdf0fd: [clangd] Add brief instructions on how to make a release for vscode-clangd…
rL325499: [clangd] Add brief instructions on how to make a release for vscode-clangd…
rCTE325499: [clangd] Add brief instructions on how to make a release for vscode-clangd…

Diff Detail

Event Timeline

hokein created this revision.Feb 19 2018, 3:19 AM
Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek. · View Herald TranscriptFeb 19 2018, 3:19 AM
Harbormaster completed remote builds in B15143: Diff 134880.Feb 19 2018, 3:21 AM
sammccall accepted this revision.Feb 19 2018, 5:56 AM

thanks! couple of nits

clangd/clients/clangd-vscode/README.md
55

Is this true? Might be more accurate to say that changes to clangd-vscode are not released until a new version is published to the marketplace.

61

increase the version number in (whatever the filename is), and commit that change?

This revision is now accepted and ready to land.Feb 19 2018, 5:56 AM
hokein updated this revision to Diff 134900.Feb 19 2018, 6:02 AM
hokein marked an inline comment as done.

Address review comments.

hokein marked an inline comment as done.Feb 19 2018, 6:03 AM
hokein added inline comments.
clangd/clients/clangd-vscode/README.md
61

Oops, I forgot this one.

Harbormaster completed remote builds in B15148: Diff 134900.Feb 19 2018, 6:03 AM
Closed by commit rCTE325499: [clangd] Add brief instructions on how to make a release for vscode-clangd… (authored by hokein). · Explain WhyFeb 19 2018, 6:04 AM
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.

Revision Contents

PathSize
clangd/
clients/
clangd-vscode/
25 lines

Diff 134901

clangd/clients/clangd-vscode/README.md

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
3. In order to start a development instance of VS code extended with this, run: 3. In order to start a development instance of VS code extended with this, run:
```bash ```bash
$ cd /path/to/clang-tools-extra/clangd/clients/clangd-vscode/ $ cd /path/to/clang-tools-extra/clangd/clients/clangd-vscode/
$ npm install $ npm install
$ code . $ code .
# When VS Code starts, press <F5>. # When VS Code starts, press <F5>.
``` ```
## Publish to VS Code Marketplace
New changes to `clangd-vscode` are not released until a new version is published
sammccallUnsubmitted
Done
ReplyInline Actions

Is this true? Might be more accurate to say that changes to clangd-vscode are not released until a new version is published to the marketplace.

sammccall: Is this true? Might be more accurate to say that changes to `clangd-vscode` are not released…
to the marketplace.
### Requirements
* Make sure install the `vsce` command (`npm install -g vsce`)
* `llvm-vs-code-extensions` account
sammccallUnsubmitted
Done
ReplyInline Actions

increase the version number in (whatever the filename is), and commit that change?

sammccall: increase the version number in (whatever the filename is), and commit that change?
hokeinAuthorUnsubmitted
Not Done
ReplyInline Actions

Oops, I forgot this one.

hokein: Oops, I forgot this one.
* Bump the version in `package.json`, and commit the change to upstream
The extension is published under `llvm-vs-code-extensions` account, which is
currently maintained by clangd developers. If you want to make a new release,
please contact cfe-dev@lists.llvm.org.
### Steps
```bash
$ cd /path/to/clang-tools-extra/clangd/clients/clangd-vscode/
# For the first time, you need to login in the account. vsce will ask you for
the account password, and remember it for future commands.
$ vsce login llvm-vs-code-extensions
$ vsce publish
```