This is an archive of the discontinued LLVM Phabricator instance.

Differential D43437

[clangd] Fix link failures for Preprocessor::addCommentHandler
ClosedPublic

Authored by aheejin on Feb 18 2018, 12:22 AM.

Details

Reviewers
ioeric
Commits
rGf4a29252fba7: [clangd] Fix link failures for Preprocessor::addCommentHandler
rCTE325458: [clangd] Fix link failures for Preprocessor::addCommentHandler
rL325458: [clangd] Fix link failures for Preprocessor::addCommentHandler
Summary

D42640 adds calls to Preprocessor::addCommentHandler in
unittests/clangd/SymbolCollectorTests.cpp and
clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp but does not
link clangLex library. This causes undefined reference errors when
built with -DBUILD_SHARED_LIBS=ON.

Diff Detail

Repository
rL LLVM

Event Timeline

aheejin created this revision.Feb 18 2018, 12:22 AM
Harbormaster completed remote builds in B15131: Diff 134825.Feb 18 2018, 12:22 AM
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov and 2 others. · View Herald TranscriptFeb 18 2018, 12:22 AM
ioeric accepted this revision.Feb 18 2018, 2:37 AM
ioeric added a subscriber: malaperle.

lg. Thanks!

fyi, @malaperle also sent D43429 for the same fix but has not landed it yet ;)

This revision is now accepted and ready to land.Feb 18 2018, 2:37 AM
aheejin retitled this revision from Fix link failures for Preprocessor::addCommentHandler to [clangd] Fix link failures for Preprocessor::addCommentHandler.Feb 18 2018, 2:48 AM
Closed by commit rL325458: [clangd] Fix link failures for Preprocessor::addCommentHandler (authored by aheejin). · Explain WhyFeb 18 2018, 2:52 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptFeb 18 2018, 2:52 AM

Revision Contents

PathSize
clang-tools-extra/
trunk/
clangd/
global-symbol-builder/
1 line
unittests/
clangd/
1 line

Diff 134828

clang-tools-extra/trunk/clangd/global-symbol-builder/CMakeLists.txt

Show All 9 Lines
target_link_libraries(global-symbol-builder target_link_libraries(global-symbol-builder
PRIVATE PRIVATE
clangAST clangAST
clangIndex clangIndex
clangDaemon clangDaemon
clangBasic clangBasic
clangFrontend clangFrontend
clangLex
clangTooling clangTooling
) )

clang-tools-extra/trunk/unittests/clangd/CMakeLists.txt

Show All 32 Lines
target_link_libraries(ClangdTests target_link_libraries(ClangdTests
PRIVATE PRIVATE
clangBasic clangBasic
clangDaemon clangDaemon
clangFormat clangFormat
clangFrontend clangFrontend
clangIndex clangIndex
clangLex
clangSema clangSema
clangTooling clangTooling
clangToolingCore clangToolingCore
LLVMSupport LLVMSupport
) )