This is an archive of the discontinued LLVM Phabricator instance.

Differential D43413

AMDGPU/LLD: Remove the use of binary file from one of the AMDGPU tests
ClosedPublic

Authored by kzhuravl on Feb 16 2018, 2:45 PM.

Details

Reviewers
ruiu
t-tye
Commits
rG82a61991404f: AMDGPU/LLD: Remove the use of binary file from one of the AMDGPU tests
rLLD325404: AMDGPU/LLD: Remove the use of binary file from one of the AMDGPU tests
rL325404: AMDGPU/LLD: Remove the use of binary file from one of the AMDGPU tests
Summary

This is the follow up for D39140.

Diff Detail

Event Timeline

kzhuravl created this revision.Feb 16 2018, 2:45 PM
Herald added subscribers: arichardson, tpr, dstuttard and 4 others. · View Herald TranscriptFeb 16 2018, 2:45 PM
ruiu accepted this revision.Feb 16 2018, 2:50 PM

LGTM

Thank you for doing this!

This revision is now accepted and ready to land.Feb 16 2018, 2:50 PM
t-tye accepted this revision.Feb 16 2018, 2:51 PM

LGTM

Closed by commit rL325404: AMDGPU/LLD: Remove the use of binary file from one of the AMDGPU tests (authored by kzhuravl). · Explain WhyFeb 16 2018, 2:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
ELF/
Inputs/
6 lines

Diff 134729

test/ELF/Inputs/amdgpu-kernel-2.o

  • This is a binary file.
PropertyOld ValueNew Value
svn:mime-typeapplication/octet-stream
\ No newline at end of property		null

test/ELF/amdgpu-elf-flags-err.s

# RUN: llvm-mc -triple amdgcn-amd-amdhsa -mcpu=gfx803 -filetype=obj %S/Inputs/amdgpu-kernel-0.s -o %t-0.o # RUN: llvm-mc -triple amdgcn-amd-amdhsa -mcpu=gfx802 -filetype=obj %S/Inputs/amdgpu-kernel-0.s -o %t-0.o
# RUN: llvm-mc -triple amdgcn-amd-amdhsa -mcpu=gfx803 -filetype=obj %S/Inputs/amdgpu-kernel-1.s -o %t-1.o # RUN: llvm-mc -triple amdgcn-amd-amdhsa -mcpu=gfx803 -filetype=obj %S/Inputs/amdgpu-kernel-1.s -o %t-1.o
# RUN: not ld.lld -shared %t-0.o %t-1.o %S/Inputs/amdgpu-kernel-2.o -o %t.so 2>&1 | FileCheck %s # RUN: not ld.lld -shared %t-0.o %t-1.o -o %t.so 2>&1 | FileCheck %s
# REQUIRES: amdgpu # REQUIRES: amdgpu
# CHECK: error: incompatible e_flags: {{.*}}amdgpu-kernel-2.o # CHECK: error: incompatible e_flags: {{.*}}-1.o