This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] stop buffer_store being moved illegally
ClosedPublic

Authored by tpr on Feb 15 2018, 3:46 AM.

Details

Summary

The machine instruction scheduler was illegally moving a buffer store
past a buffer load with the same descriptor and offset. Fixed by marking
buffer ops as mayAlias and isAliased. This may be overly conservative,
and we may need to revisit.

Change-Id: Iff3173d9e0653e830474546276ab9d30318b8ef7

Diff Detail

Event Timeline

tpr created this revision.Feb 15 2018, 3:46 AM
tpr added a reviewer: Restricted Project.Feb 15 2018, 4:12 AM
arsenm accepted this revision.Feb 19 2018, 8:10 AM

LGTM except test cleanups

test/CodeGen/AMDGPU/buffer-schedule.ll
4–5

Remove these and specify the full triple to the llc run line

20–21

Extra copies

23

Delete attribute comments

This revision is now accepted and ready to land.Feb 19 2018, 8:10 AM
This revision was automatically updated to reflect the committed changes.