Page MenuHomePhabricator

[dotest] Add ability to skip tests based on build configuration
AbandonedPublic

Authored by labath on Feb 14 2018, 8:06 AM.

Details

Summary

Some lldb features depend on xml support. Tests exercising that
functionality can only succeed if lldb was built with xml support. Right
now we have one such test, and another waiting in a patch that's blocked
on this.

This patch implements that functionality by exporting the build
configuration from cmake via configure_file (for the XCode build, I add
a hard-coded configuration file). Then, in dotest we parse this file and
use it to initialize a "feature" configuration variable. I chose a
fairly generic name as other as I anticipate adding other things here,
for example, the list of configured llvm targets. Lastly, I add a
new "features" option to the skipIf decorator enable skipping based on
configured features

The TestTargetXMLArch is updated to match on the xml feature instead of
incorrectly matching on the host platform.

Event Timeline

labath created this revision.Feb 14 2018, 8:06 AM

After all the work he did on the testsuite I think Adrian is in a good position to review this one.

aprantl accepted this revision.Feb 14 2018, 8:38 AM
This revision is now accepted and ready to land.Feb 14 2018, 8:38 AM
labath abandoned this revision.Feb 16 2018, 1:33 AM

It looks like we'll do something like D43333 instead...