[WebAssembly] Unify concepts of disgarded and non-live input chunks. NFC.
ClosedPublic

Authored by sbc100 on Tue, Feb 13, 11:29 AM.

Details

Summary

It seems redundant to store this information twice. None of the
locations where this bit is checks cares about the distinction.

This simplifies the code and avoids having to reason about two
different concepts of aliveness.

Diff Detail

Repository
rLLD LLVM Linker
sbc100 created this revision.Tue, Feb 13, 11:29 AM
sbc100 updated this revision to Diff 134090.Tue, Feb 13, 11:31 AM
  • update comment
sbc100 edited the summary of this revision. (Show Details)Tue, Feb 13, 11:33 AM
sbc100 added reviewers: ruiu, ncw.
sbc100 edited the summary of this revision. (Show Details)
ruiu accepted this revision.Tue, Feb 13, 11:37 AM

LGTM

This revision is now accepted and ready to land.Tue, Feb 13, 11:37 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.
ncw added a comment.Wed, Feb 14, 4:16 AM

Cool, looks like it should work.

NB. Discarded/Live were distinguished based on the ELF and COFF implementations, so maybe we'll find a reason to bring the distinction back later - or maybe those can be simplified too, just to use the Live bit?