This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Change constant addr space to 4
ClosedPublic

Authored by yaxunl on Feb 11 2018, 1:08 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

yaxunl created this revision.Feb 11 2018, 1:08 PM
t-tye accepted this revision.Feb 12 2018, 8:54 AM

LGTM. Cleanup comments can be done as a separate patch at a later time.

lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp
54–62 ↗(On Diff #133801)

Since there is now only a single address space mapping can this simply be deleted?

63 ↗(On Diff #133801)

Can then rename this to simply ASAliasRules

80–88 ↗(On Diff #133801)

Ditto.

lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
945–951 ↗(On Diff #133801)

Now there is only a single address mapping presumably this can be eliminated?

This revision is now accepted and ready to land.Feb 12 2018, 8:54 AM

Will clean up the old addr space mapping with separate patch.

This revision was automatically updated to reflect the committed changes.