Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM. Cleanup comments can be done as a separate patch at a later time.
lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp | ||
---|---|---|
54–62 ↗ | (On Diff #133801) | Since there is now only a single address space mapping can this simply be deleted? |
63 ↗ | (On Diff #133801) | Can then rename this to simply ASAliasRules |
80–88 ↗ | (On Diff #133801) | Ditto. |
lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp | ||
945–951 ↗ | (On Diff #133801) | Now there is only a single address mapping presumably this can be eliminated? |