Page MenuHomePhabricator

[clang-format] Do not break before long string literals in protos
ClosedPublic

Authored by krasimir on Feb 6 2018, 5:35 AM.

Details

Summary

This patch is a follow-up to r323319 (which disables string literal breaking for
text protos) and it disables breaking before long string literals.

For example this:

keyyyyy: "long string literal"

used to get broken into:

keyyyyy:
    "long string literal"

While at it, I also enabled it for LK_Proto and fixed a bug in the mustBreak code.

Diff Detail

Repository
rL LLVM

Event Timeline

krasimir created this revision.Feb 6 2018, 5:35 AM
krasimir updated this revision to Diff 132978.Feb 6 2018, 5:38 AM
  • Update comment
djasper accepted this revision.Feb 8 2018, 1:54 AM

Looks good.

This revision is now accepted and ready to land.Feb 8 2018, 1:54 AM
This revision was automatically updated to reflect the committed changes.