This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add ELFObjectFileBase::getRISCVFeatures let llvm-objdump could get RISCV target feature

Authored by shiva0217 on Jan 28 2018, 6:07 PM.



llvm-objdump could get C feature by ELF::EF_RISCV_RVC e_flag, so then we don't add -mattr=+c on the command line.

Diff Detail


Event Timeline

shiva0217 created this revision.Jan 28 2018, 6:07 PM
asb accepted this revision.Feb 1 2018, 6:07 AM

Nice improvement - looks good to me. Thanks!

This revision is now accepted and ready to land.Feb 1 2018, 6:07 AM
asb added a comment.Feb 1 2018, 6:10 AM

Looks like there are two more test files you can update to not pass -mattr=+c to llvm-objdump:

  • cnop.s
  • fixups-compressed.s

Could you please update those too when you commit.

This revision was automatically updated to reflect the committed changes.