This patch contains a support of lowering 'nof' flag in https://reviews.llvm.org/D41944
Currently this support is for X86 target and other target may provide their own implementation.
Details
Diff Detail
Event Timeline
CodeGen/SelectionDAG/LegalizeVectorOps.cpp | ||
---|---|---|
755 | What guarantees HalfVT is a legal type for the target? | |
CodeGen/X86/combine-sdiv.ll | ||
265 | FIXME and TODO are the common prefixes for comments like this. No one is ever going to look for "FIX IT" | |
Target/X86/X86ISelLowering.cpp | ||
38113 | hasAVX2 implies hasAVX512. But what's special about AVX2 here? |
fixed craig notes
CodeGen/SelectionDAG/LegalizeVectorOps.cpp | ||
---|---|---|
755 | In fact I did this only because as you may notice that i use wider FP types (i32 goes to f64), I assume that when we get to this function the original integer vector type is legal, so if I enlarge the FP type it may be not legal anymore. because of that i did the split. | |
Target/X86/X86ISelLowering.cpp | ||
38113 | fixed. |
CodeGen/SelectionDAG/LegalizeVectorOps.cpp | ||
---|---|---|
755 | There is another type legalizer run after vector ops legalization, but it shouldn't be legalizing vector types. It's intended to legalize scalar types created by unrolling. |
What guarantees HalfVT is a legal type for the target?