This is an archive of the discontinued LLVM Phabricator instance.

libcxx: Stop using private MSVC macros in the exception implementation.
ClosedPublic

Authored by pcc on Jan 16 2018, 7:38 PM.

Details

Summary

Inline the provided "fallback" definitions (which seem to always be
taken) that expand to __cdecl into users. The fallback definitions
for the *CRTIMP* macros were wrong in the case where the library is
being linked statically, so define our own macro as a replacement.

Event Timeline

pcc created this revision.Jan 16 2018, 7:38 PM
smeenai accepted this revision.Jan 16 2018, 8:19 PM

LGTM.

This revision is now accepted and ready to land.Jan 16 2018, 8:19 PM
This revision was automatically updated to reflect the committed changes.